Skip to content

Add argo rollout status#1520

Merged
twerthi merged 2 commits intomasterfrom
add-argo-rollout-status
Jun 12, 2024
Merged

Add argo rollout status#1520
twerthi merged 2 commits intomasterfrom
add-argo-rollout-status

Conversation

@twerthi
Copy link
Copy Markdown
Contributor

@twerthi twerthi commented Jun 12, 2024


Background

This PR adds a new template that will get the status of an Argo Rollout.

Results

It's new, all new, brand spanking new.

Before

Template didn't exist.

After

A new, shiny, and exceptionally written template :P

Pre-requisites

  • Id should be a GUID that is not 00000000-0000-0000-0000-000000000000
    • NOTE If you are modifying an existing step template, please make sure that you do not modify the Id property (updating the Id will break the Library sync functionality in Octopus).
  • Version should be incremented, otherwise the integration with Octopus won't update the step template correctly
  • Parameter names should not start with $
  • Step template parameter names (the ones declared in the JSON, not the script body) should be prefixed with a namespace so that they are less likely to clash with other user-defined variables in Octopus (see this issue). For example, use an abbreviated name of the step template or the category of the step template).
  • LastModifiedBy field must be present, and (optionally) updated with the correct author
  • The best practices documented here have been applied
  • If a new Category has been created:
    • An image with the name {categoryname}.png must be present under the step-templates/logos folder
    • The switch in the humanize function in gulpfile.babel.js must have a case statement corresponding to it

Copy link
Copy Markdown
Contributor

@hnrkndrssn hnrkndrssn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, a nice, shiny and exceptionally written step :shipit:

@twerthi twerthi merged commit eafdcac into master Jun 12, 2024
@twerthi twerthi deleted the add-argo-rollout-status branch June 12, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants