Skip to content

Migrate to GHCR for Octoterra#1528

Merged
mcasperson merged 1 commit intomasterfrom
mattc/migrate-to-ghcr
Jul 4, 2024
Merged

Migrate to GHCR for Octoterra#1528
mcasperson merged 1 commit intomasterfrom
mattc/migrate-to-ghcr

Conversation

@mcasperson
Copy link
Copy Markdown
Contributor

@mcasperson mcasperson commented Jul 4, 2024

Background

DockerHub appears to be restricting access to dynamic workers. This PR uses the Octoterra Docker images in the GitHub Container Registry.

Results

Pull from ghcr.io/octopussolutionsengineering/octoterra rather than octopussamples/octoterra.

Pre-requisites

  • Id should be a GUID that is not 00000000-0000-0000-0000-000000000000
    • NOTE If you are modifying an existing step template, please make sure that you do not modify the Id property (updating the Id will break the Library sync functionality in Octopus).
  • Version should be incremented, otherwise the integration with Octopus won't update the step template correctly
  • Parameter names should not start with $
  • Step template parameter names (the ones declared in the JSON, not the script body) should be prefixed with a namespace so that they are less likely to clash with other user-defined variables in Octopus (see this issue). For example, use an abbreviated name of the step template or the category of the step template).
  • LastModifiedBy field must be present, and (optionally) updated with the correct author
  • The best practices documented here have been applied
  • If a new Category has been created:
    • An image with the name {categoryname}.png must be present under the step-templates/logos folder
    • The switch in the humanize function in gulpfile.babel.js must have a case statement corresponding to it

Fixes # . If there is an open issue that this PR fixes add it here, otherwise just remove this line

@mcasperson mcasperson enabled auto-merge (squash) July 4, 2024 03:08
Copy link
Copy Markdown
Contributor

@harrisonmeister harrisonmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mcasperson mcasperson merged commit cae6e3b into master Jul 4, 2024
@mcasperson mcasperson deleted the mattc/migrate-to-ghcr branch July 4, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants