fix: correct history link handling in the library UI#1667
Open
bcullman wants to merge 1 commit intoOctopusDeploy:masterfrom
Open
fix: correct history link handling in the library UI#1667bcullman wants to merge 1 commit intoOctopusDeploy:masterfrom
bcullman wants to merge 1 commit intoOctopusDeploy:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
This PR fixes the
Historylink on Library template detail pages.The current behavior has two problems:
/opt/buildagent/.../step-templates/<file>.jsonpath to be embedded into the final URLResults
The History link now preserves the current-
masterGitHub URL shape understep-templates/<template>.json, uses cross-platform filename extraction, and opens in a new tab.Before
HistoryUrldepended onfile.path.split("\\")/opt/buildagent/.../step-templates/<file>.jsonpath instead of just<file>.jsonAfter
HistoryUrlusespath.basename(file.path)for cross-platform filename extractiontarget="_blank"andrel="noopener noreferrer"Pre-requisites
Idshould be a GUID that is not00000000-0000-0000-0000-000000000000Idproperty (updating theIdwill break the Library sync functionality in Octopus).Versionshould be incremented, otherwise the integration with Octopus won't update the step template correctly$LastModifiedByfield must be present, and (optionally) updated with the correct authorCategoryhas been created:{categoryname}.pngmust be present under thestep-templates/logosfolderswitchin thehumanizefunction ingulpfile.babel.jsmust have acasestatement corresponding to itFixes #1666