IIS AppPool - Create: added retry logic and parameter cleanup#211
Merged
hnrkndrssn merged 2 commits intoOctopusDeploy:masterfrom Sep 4, 2015
Merged
IIS AppPool - Create: added retry logic and parameter cleanup#211hnrkndrssn merged 2 commits intoOctopusDeploy:masterfrom
hnrkndrssn merged 2 commits intoOctopusDeploy:masterfrom
Conversation
Added Execute-WithRetry to make saving IIS config more forgiving Fixed consistency issues with Queue Length and Regular Time Interval parameters
gregjhogan
changed the title
gregjhogan
changed the title
If something changes the IIS config outside of this script after the application pool is copied into a variable, attempting to commit the IIS config causes the following error: Cannot commit configuration changes because the file has changed on disk
Contributor
Author
|
I updated my patch because I discovered that the code I put in the retry block always fails if something else (perhaps another deployment) modifies the IIS config in between the script reading the application pool config and attempting to commit the IIS config. |
hnrkndrssn
added a commit
that referenced
this pull request
Sep 4, 2015
IIS AppPool - Create: added retry logic and parameter cleanup
Contributor
|
Thanks very much for your contribution, this will deployed to production today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Execute-WithRetry to make saving IIS config more forgiving (it fails every once in a while due to the file being locked)
Fixed consistency issues with Queue Length and Regular Time Interval parameters