Skip to content

Show progress of upgrading the database schema.#2

Merged
michaelnoonan merged 6 commits into
masterfrom
enh-showdbupgrade
Jun 5, 2017
Merged

Show progress of upgrading the database schema.#2
michaelnoonan merged 6 commits into
masterfrom
enh-showdbupgrade

Conversation

@michaelnoonan
Copy link
Copy Markdown
Contributor

This allows the logs folder to be opened if a command fails.
Historically, we've used ArgumentException to report command argument validation problems, and ignore the stack trace. If an "unexpected" ArgumentException is thrown, we lose all the stack trace information. We should actually use a special exception like ControlledFailureException to achieve the same result, and allow ArgumentExceptions from other places to flow unencumbered.
Recent changes means the home directory does not need to be configured separately to creating the instance.
Copy link
Copy Markdown
Contributor

@matt-richardson matt-richardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants