Merged
Conversation
mik-ky
force-pushed
the
ck/missing-packages-warning
branch
3 times, most recently
from
25370c5 to
de3e9ad
Compare
mik-ky
commented
May 27, 2025
| // | ||
| //emptyDeploymentPreviews := fixtures.EmptyDeploymentPreviews() | ||
| //api.ExpectRequest(t, "POST", "/api/Spaces-1/releases/"+release19.ID+"/deployments/previews").RespondWith(&emptyDeploymentPreviews) | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Cleaning up some commented out code
mik-ky
force-pushed
the
ck/missing-packages-warning
branch
2 times, most recently
from
252981d to
1e8a4c7
Compare
tothegills
approved these changes
May 28, 2025
Collaborator
tothegills
left a comment
tothegills
left a comment
There was a problem hiding this comment.
Code looks good, manually tested, great test coverage.
| func promptMissingPackages(octopus *octopusApiClient.Client, stdout io.Writer, asker question.Asker, release *releases.Release) bool { | ||
| missingPackages, err := releases.GetMissingPackages(octopus, release) | ||
| if err != nil { | ||
| // We don't want to prevent deployments from going through because of this check |
mik-ky
force-pushed
the
ck/missing-packages-warning
branch
from
1e8a4c7 to
b5b93ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds missing packages warning when deploying a release. User can continue to deploy if they wish, and if the
--no- promptflag is passed it bypasses this check (as no questions are asked).This is sitting behind a feature flag.
Changes
No, don't continue
Yes, continue
--no-prompt flag
Requires OctopusDeploy/go-octopusdeploy#335
[sc-110366]