fix: remove unstable selector labels in mssql and octopus statefulsets

[liam-mackie]

Fixed issue

matchLabels (which is immutable) included label helm.sh/chart had dynamic value. That was preventing chart from upgrading

kind: StatefulSet
metadata:
  name: octopus-deploy
spec:
  selector:
    matchLabels:
      app.kubernetes.io/component: octopus-server
      app.kubernetes.io/instance: octopus-deploy
      app.kubernetes.io/managed-by: Helm
      app.kubernetes.io/name: octopus-deploy
      helm.sh/chart: octopusdeploy-helm-1.12.0 # this is dynamic value that causing issues during helm upgrade command

[changeset-bot]

🦋 Changeset detected

Latest commit: 853e3d1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
octopus-deploy	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[philipkotliyakov]

I would add a way to disable this hook (and the extra role/rolebinding/service account) since once the user upgrades and all the stateful sets are recreated with the correct labels, there is no longer need to run the hook.

[oleksandr-codefresh]

what default behaviour u suggest?

• enabled: false - that makes things inconvenient, as requires user to read docs once meet issue and we don't know from which version to which they gonna update.

• enabled: true - I guess in most cases users also won't bother about having this extra value

[oleksandr-codefresh]

added

hooks:
  enableSelectorLabelsFix: true