Skip to content

fix(elasticsearch): drop dict-literal default from restart handler conditionals #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Oddly merged 1 commit into from
Apr 23, 2026
Merged

fix(elasticsearch): drop dict-literal default from restart handler conditionals #140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions roles/elasticsearch/handlers/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
when:
- not ansible_check_mode
- elasticsearch_enable | bool
- not (_elasticsearch_freshstart | default({'changed': false})).changed | bool
- not (_elasticsearch_freshstart_security | default({'changed': false})).changed | bool
- not (_elasticsearch_freshstart.changed | default(false) | bool)
- not (_elasticsearch_freshstart_security.changed | default(false) | bool)
- not _elasticsearch_rolling_upgrade_performed | default(false) | bool

- name: Restart Elasticsearch directly
Expand All @@ -20,8 +20,8 @@
- >
elasticsearch_config_restart_strategy == 'direct'
or groups[elasticstack_elasticsearch_group_name] | default([]) | length <= 1
- not (_elasticsearch_freshstart | default({'changed': false})).changed | bool
- not (_elasticsearch_freshstart_security | default({'changed': false})).changed | bool
- not (_elasticsearch_freshstart.changed | default(false) | bool)
- not (_elasticsearch_freshstart_security.changed | default(false) | bool)
- not _elasticsearch_rolling_upgrade_performed | default(false) | bool

- name: Clear direct Elasticsearch restart request
Expand All @@ -34,8 +34,8 @@
- >
elasticsearch_config_restart_strategy == 'direct'
or groups[elasticstack_elasticsearch_group_name] | default([]) | length <= 1
- not (_elasticsearch_freshstart | default({'changed': false})).changed | bool
- not (_elasticsearch_freshstart_security | default({'changed': false})).changed | bool
- not (_elasticsearch_freshstart.changed | default(false) | bool)
- not (_elasticsearch_freshstart_security.changed | default(false) | bool)
- not _elasticsearch_rolling_upgrade_performed | default(false) | bool

- name: Restart Elasticsearch rolling
Expand All @@ -47,8 +47,8 @@
- elasticsearch_enable | bool
- elasticsearch_config_restart_strategy == 'rolling'
- groups[elasticstack_elasticsearch_group_name] | default([]) | length > 1
- not (_elasticsearch_freshstart | default({'changed': false})).changed | bool
- not (_elasticsearch_freshstart_security | default({'changed': false})).changed | bool
- not (_elasticsearch_freshstart.changed | default(false) | bool)
- not (_elasticsearch_freshstart_security.changed | default(false) | bool)
- not _elasticsearch_rolling_upgrade_performed | default(false) | bool

- name: Restart kibana if available for elasticsearch certificates
Expand Down
Loading