Replace bare ansible_date_time with ansible_facts.date_time#54
Merged
Conversation
Oddly
force-pushed
the
fix/ansible-date-time-deprecation
branch
9 times, most recently
from
d5fceec to
90599a9
Compare
Ansible 2.20 deprecated INJECT_FACTS_AS_VARS and 2.24 will remove it entirely. Three role task files and two molecule converge files used the bare ansible_date_time form which triggers deprecation warnings on every run. Switched to the ansible_facts.date_time accessor throughout. Closes #44
Oddly
force-pushed
the
fix/ansible-date-time-deprecation
branch
from
90599a9 to
f8244b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #44.
Ansible 2.20 already emits INJECT_FACTS_AS_VARS deprecation warnings for bare fact access like
ansible_date_time.date, and Ansible 2.24 will remove the legacy injection entirely. Three role task files (cert_backup, cert_check_expiry, cert_expiry_warn) and two molecule converge files used the bare form. This replaces all occurrences withansible_facts.date_time.*, matching the style already used everywhere else in the codebase.