Skip to content
This repository was archived by the owner on Apr 17, 2018. It is now read-only.

Conversation

@Zaturrby
Copy link
Contributor

Adds new valid-modes to allow the overlays to be accessed.

Things to think about:

  1. Some overlays will not always be valid (like new-user for a recurring user)
  2. Naming of the overlays, the names chosen now match the ones chosen in offcourse-web.

@yeehaa123 yeehaa123 closed this Oct 26, 2016
@yeehaa123 yeehaa123 reopened this Oct 26, 2016
@yeehaa123 yeehaa123 merged commit 072e090 into master Oct 26, 2016
@yeehaa123
Copy link
Collaborator

yeehaa123 commented Oct 26, 2016

@Zaturrby

  1. agree, so we'll have to dynamically limit the set of current valid states based on the rest of the app state
  2. I think we can get away with 4 modes: normal-mode (don't call it view-mode it's confusing, because of the naming collision with viewmodels, etc), edit-mode, auth-mode, and focus-mode. The variations (new-user, etc.) can either be derived from appstate (auth can only be in new-user state if there is no valid user in our db for instance) or stored in a local atom.

Can you refactor this accordingly? I already made an issue (#2) for this.

@Zaturrby
Copy link
Contributor Author

@yeehaa123 Will do!

@Zaturrby Zaturrby deleted the pr-branch branch November 28, 2016 11:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants