core: Fix RecentWasms cache bug by using pointers in methods #581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KolbyML
force-pushed
the
Fix-RecentWasms-cache-bug-by-using-pointers-in-methods
branch
from
e377a66 to
ff9a16e
Compare
KolbyML
changed the title
pmikolajczyk41
previously approved these changes
Nov 20, 2025
Member
pmikolajczyk41
left a comment
pmikolajczyk41
left a comment
There was a problem hiding this comment.
LGTM + I confirm that the test wouldn't pass without the changes
pmikolajczyk41
approved these changes
Nov 24, 2025
eljobe
deleted the
Fix-RecentWasms-cache-bug-by-using-pointers-in-methods
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves NIT-4128
pulled in by: OffchainLabs/nitro#4035