Prepare nitro-test node for txn filter reporting feature - NIT-4675#186
Open
mahdy-nasr wants to merge 2 commits intomasterfrom
Open
Prepare nitro-test node for txn filter reporting feature - NIT-4675#186mahdy-nasr wants to merge 2 commits intomasterfrom
mahdy-nasr wants to merge 2 commits intomasterfrom
Conversation
mahdy-nasr
commented
Apr 16, 2026
| server.listen(8080, '0.0.0.0', () => { | ||
| console.log('Report receiver listening on :8080'); | ||
| }); | ||
| // Handler must be async and await a never-resolving promise so yargs |
Author
There was a problem hiding this comment.
this part took good time from me to fix. thus leave comments for future
MishkaRogachev
previously approved these changes
Apr 17, 2026
There was a problem hiding this comment.
Pull request overview
Prepares the nitro-test environment to run the upcoming transaction filtering report framework by adding new services (SQS emulation + report forwarder + receiver) and wiring them into the existing test-node.bash/scripts-based config generation flow.
Changes:
- Add
--l2-filtering-reportflag totest-node.bash, wiring it to config generation and to bringing up the new containers. - Extend the scripts CLI with commands to generate ElasticMQ and filtering-report configs, plus a lightweight report-receiver HTTP server.
- Add
elasticmq,filtering-report, andreport-receiverservices todocker-compose.yaml.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
test-node.bash |
Adds a new mode flag and ensures the new services/config steps are executed when enabled. |
scripts/index.ts |
Registers new script commands and switches yargs invocation to parseAsync() for async commands. |
scripts/config.ts |
Adds config writers for ElasticMQ/filtering-report, applies filtering-report config to sequencer config, and adds a report receiver server command. |
docker-compose.yaml |
Introduces ElasticMQ, filtering-report, and report-receiver containers needed for reporting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes NIT-4675
Test Plan Preperation
1- disabled eth-call filtering
2- Merged this PR with this PR locally as nitro-test base.
Test procedure done 1
1- Prepared alice account with 1eth
2- Send to bob without filtering added.
= Expected result pass (validated)
test procedure done 2
2- Add alice to filtered address
3- Send to Bob
= Transaction failed with error.
= Report receiver container received the full report.
Here was the container logs for report receiver: