Skip to content

Conversation

@pmikolajczyk41
Copy link
Member

@pmikolajczyk41 pmikolajczyk41 commented Nov 10, 2025

Wrapping DataPoster's internal state into an auxiliary locking state to improve reliability and safety of the mutations.

closes NIT-4103

@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2025

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
2164 2 2162 0
View the top 2 failed tests by shortest run time
TestVersion40
Stack Traces | 8.260s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
=== PAUSE TestVersion40
=== CONT  TestVersion40
    precompile_inclusion_test.go:90: goroutine 455166 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.3/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x40c3730, 0xc000cb4700}, {0x40810a0, 0xc07638cb70}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/system_tests.Require(0xc000cb4700, {0x40810a0, 0xc07638cb70}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/system_tests/common_test.go:1759 +0x5d
        github.com/offchainlabs/nitro/system_tests.testPrecompiles(0xc000cb4700, 0x28, {0xc07601bdf8, 0x5, 0x39?})
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:90 +0x371
        github.com/offchainlabs/nitro/system_tests.TestVersion40(0xc000cb4700?)
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:71 +0x64b
        testing.tRunner(0xc000cb4700, 0x3d09800)
        	/opt/hostedtoolcache/go/1.25.3/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.3/x64/src/testing/testing.go:1997 +0x465
        
    precompile_inclusion_test.go:90: �[31;1m [] execution aborted (timeout = 5s) �[0;0m
--- FAIL: TestVersion40 (8.26s)
TestOutOfGasInStorageCacheFlush
Stack Traces | 34.310s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
�[90mi	depth	opcode	stack�[0;0m
�[90m0	1	SLOAD	[0x15fed0451499512d95f3ec5a41c878b9de55f21878b5b4e190d4667ec709b400]�[0;0m
�[90m1	1	SLOAD	[0x3c79da47f96b0f39664f73c0a1f350580be90742947dddfa21ba64d578dfe600]�[0;0m
�[90m2	1	CALLDATACOPY	[0x0 0x0 0x0]�[0;0m
�[90m3	1	STOP	[]�[0;0m
�[90mpanic-after-write: len 0.14K vs 0.20K�[0;0m
�[90mpanic-after-write: deployed to 0x209A869BA8373Fc47655D22Ee00e38B6Bf159f0F�[0;0m
�[90mposted new batch 15�[0;0m
�[90mTime to activate panic-after-write: 394.472583ms�[0;0m
�[90mCall trace:�[0;0m
�[90mi	depth	opcode	stack�[0;0m
�[90m0	1	SLOAD	[0x15fed0451499512d95f3ec5a41c878b9de55f21878b5b4e190d4667ec709b400]�[0;0m
�[90m1	1	SLOAD	[0x3c79da47f96b0f39664f73c0a1f350580be90742947dddfa21ba64d578dfe600]�[0;0m
�[90m2	1	CALLDATACOPY	[0x0 0x0 0x0]�[0;0m
�[90m3	1	REVERT	[0x12 0x0]�[0;0m
�[90m4	1	STOP	[]�[0;0m
ERROR[11-12|09:46:55.185] Dangling trie nodes after full cleanup
ERROR[11-12|09:46:55.290] latest L1 block is old                   l1Block=0 l1Timestamp=1970-01-01T00:00:00+0000 age=489705h46m55.29050471s
INFO [11-12|09:46:55.936] HTTP server stopped                      endpoint=127.0.0.1:33677
TRACE[11-12|09:46:55.936] P2P networking is spinning down

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

MishkaRogachev
MishkaRogachev previously approved these changes Nov 10, 2025
@eljobe eljobe assigned pmikolajczyk41 and unassigned eljobe Nov 12, 2025
@eljobe eljobe enabled auto-merge November 12, 2025 09:33
@eljobe eljobe added this pull request to the merge queue Nov 12, 2025
Merged via the queue into master with commit 29cfad2 Nov 12, 2025
25 checks passed
@eljobe eljobe deleted the pmikolajczyk/nit-4103-data-poster-state branch November 12, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants