Rename database variable names #4155

bragaigor · 2025-12-18T14:11:02Z

Rename database variable names to comply with Consensus and Execution Split in codebase. New names are consensusDb to represent Consensus DB and executionDb to represent chain DB handled by Execution layer.

Closes NIT-4200

codecov · 2025-12-18T14:29:22Z

Codecov Report

❌ Patch coverage is 38.07107% with 122 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.44%. Comparing base (a5fb890) to head (2578cf9).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #4155       +/-   ##
===========================================
+ Coverage   35.10%   57.44%   +22.33%     
===========================================
  Files         453      453               
  Lines       55565    55565               
===========================================
+ Hits        19507    31919    +12412     
+ Misses      32615    18863    -13752     
- Partials     3443     4783     +1340

github-actions · 2025-12-18T15:23:46Z

❌ 2 Tests Failed:

Tests completed	Failed	Passed	Skipped
4445	2	4443	0

View the top 2 failed tests by shortest run time

TestBlocksReExecutorCommitState

Stack Traces | 3.200s run time

... [CONTENT TRUNCATED: Keeping last 20 lines]
INFO [12-22|18:20:22.278]  - London:                      #0       
INFO [12-22|18:20:22.278]  - Arrow Glacier:               #0       
INFO [12-22|18:20:22.278]  - Gray Glacier:                #0       
INFO [12-22|18:20:22.278] 
INFO [12-22|18:20:22.278] Merge configured:
INFO [12-22|18:20:22.278]  - Total terminal difficulty:  0
INFO [12-22|18:20:22.278] 
INFO [12-22|18:20:22.278] Post-Merge hard forks (timestamp based):
INFO [12-22|18:20:22.278]  - Shanghai:                    @0         
INFO [12-22|18:20:22.278]  - Cancun:                      @0          blob: (target: 3, max: 6, fraction: 3338477)
INFO [12-22|18:20:22.278]  - Prague:                      @0          blob: (target: 6, max: 9, fraction: 5007716)
INFO [12-22|18:20:22.278]  - Osaka:                       @0          blob: (target: 6, max: 9, fraction: 5007716)
INFO [12-22|18:20:22.278] 
INFO [12-22|18:20:22.278] All fork specifications can be found at https://ethereum.github.io/execution-specs/src/ethereum/forks/
INFO [12-22|18:20:22.278] 
INFO [12-22|18:20:22.278] ---------------------------------------------------------------------------------------------------------------------------------------------------------
INFO [12-22|18:20:22.278] 
INFO [12-22|18:20:22.278] Loaded most recent local block           number=0   hash=8e4045..936bd5                   age=56y9mo2w
INFO [12-22|18:20:22.278] Initialized transaction indexer          range="last 2350000 blocks"
--- FAIL: TestBlocksReExecutorCommitState (3.20s)

TestArbOSVersion60

Stack Traces | 5.490s run time

... [CONTENT TRUNCATED: Keeping last 20 lines]
INFO [12-22|18:20:20.524] Writing snapshot state to disk           root=bc4975..d9ab62
INFO [12-22|18:20:20.524] Persisted trie from memory database      nodes=0   flushnodes=0 size=0.00B     flushsize=0.00B time=451ns       flushtime=0s gcnodes=0    gcsize=0.00B     gctime=0s          livenodes=0    livesize=0.00B
DEBUG[12-22|18:20:20.524] Dereferenced trie from memory database   nodes=0   size=0.00B     time=431ns       gcnodes=0    gcsize=0.00B     gctime=141ns       livenodes=0    livesize=0.00B
INFO [12-22|18:20:20.524] Blockchain stopped
TRACE[12-22|18:20:20.524] P2P networking is spinning down
DEBUG[12-22|18:20:20.524] Finality not supported, not pushing finality data to execution
WARN [12-22|18:20:20.524] Sequencer ReadFromTxQueueTimeout is higher than MaxBlockSpeed ReadFromTxQueueTimeout=1s MaxBlockSpeed=10ms
DEBUG[12-22|18:20:20.524] Executing EVM call finished              runtime="569.562µs"
DEBUG[12-22|18:20:20.524] Served eth_call                          reqid=1337 duration="607.122µs"
TRACE[12-22|18:20:20.525] Handled RPC response                     reqid=1337 duration="2.154µs"
DEBUG[12-22|18:20:20.525] Executing EVM call finished              runtime="906.831µs"
DEBUG[12-22|18:20:20.525] Served eth_call                          reqid=12   duration="962.816µs"
DEBUG[12-22|18:20:20.525] Served eth_unsubscribe                   reqid=1339 duration="12.924µs"
DEBUG[12-22|18:20:20.525] RPC server shutting down
DEBUG[12-22|18:20:20.525] Served eth_getBlockByNumber              reqid=275  duration="59.501µs"
TRACE[12-22|18:20:20.525] Handled RPC response                     reqid=1339 duration="1.082µs"
TRACE[12-22|18:20:20.525] Handled RPC response                     reqid=12   duration="2.565µs"
DEBUG[12-22|18:20:20.525] Journalled generator progress            progress=done
DEBUG[12-22|18:20:20.525] Journalled disk layer                    root=253f3f..ea8dbd
--- FAIL: TestArbOSVersion60 (5.49s)

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

diegoximenes

Requested minor change 🙂

arbnode/inbox_test.go

system_tests/pruning_test.go

arbnode/inbox_test.go

pmikolajczyk41

LGTM, just 2 minor things:

there are still some methods that use Db suffix, which is incompatible with the new variable naming - I tried to mark all such places I found (sorry for comment spam, but I tried to be helpful 😅 )
unnecessary import aliases

arbnode/node.go

cmd/mel-replay/delayed_message_db_test.go

system_tests/bold_state_provider_test.go

system_tests/fast_confirm_test.go

system_tests/pruning_test.go

cmd/nitro/init_test.go

cmd/nitro/init.go

Rename database variable names to comply with Consensus and Execution Split in codebase. Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>

Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>

bragaigor marked this pull request as ready for review December 18, 2025 15:58

bragaigor requested review from diegoximenes and pmikolajczyk41 December 18, 2025 15:59

bragaigor assigned diegoximenes Dec 18, 2025

diegoximenes requested changes Dec 18, 2025

View reviewed changes

arbnode/inbox_test.go Outdated Show resolved Hide resolved

system_tests/pruning_test.go Outdated Show resolved Hide resolved

diegoximenes assigned bragaigor and unassigned diegoximenes Dec 18, 2025

bragaigor requested a review from diegoximenes December 18, 2025 20:21

bragaigor assigned diegoximenes and unassigned bragaigor Dec 18, 2025

diegoximenes requested changes Dec 18, 2025

View reviewed changes

arbnode/inbox_test.go Outdated Show resolved Hide resolved

diegoximenes assigned bragaigor and unassigned diegoximenes Dec 18, 2025

bragaigor force-pushed the braga/rename-arbdb-consensusdb branch from 382e42f to 1285b0d Compare December 18, 2025 21:03

bragaigor assigned diegoximenes and unassigned bragaigor Dec 18, 2025

bragaigor requested a review from diegoximenes December 18, 2025 21:17

pmikolajczyk41 previously approved these changes Dec 19, 2025

View reviewed changes

bragaigor dismissed pmikolajczyk41’s stale review via e722859 December 19, 2025 11:48

bragaigor requested a review from pmikolajczyk41 December 19, 2025 11:49

pmikolajczyk41 previously approved these changes Dec 19, 2025

View reviewed changes

bragaigor dismissed pmikolajczyk41’s stale review via 07e192c December 19, 2025 12:07

bragaigor requested a review from pmikolajczyk41 December 19, 2025 12:08

pmikolajczyk41 previously approved these changes Dec 19, 2025

View reviewed changes

diegoximenes previously approved these changes Dec 19, 2025

View reviewed changes

diegoximenes assigned joshuacolvin0 and unassigned diegoximenes Dec 19, 2025

bragaigor dismissed diegoximenes’s stale review via 45accf4 December 20, 2025 00:38

bragaigor dismissed pmikolajczyk41’s stale review via 45accf4 December 20, 2025 00:38

diegoximenes previously approved these changes Dec 22, 2025

View reviewed changes

bragaigor added 8 commits December 22, 2025 14:08

Rename database variable names

44bce80

Rename database variable names to comply with Consensus and Execution Split in codebase. Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>

Rename from executionDb to executionDB

b6dae47

Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>

Update from wasmDb and consensusDb to wasmDB and consesnsusDB

0eb03ea

Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>

Update from melDb to melDB

df437f6

Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>

l2executionDb & l2consensusDb -> l2executionDB & l2consensusDB

2bd85e3

Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>

Add changelog file

d2dfe2c

Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>

Rename other instances of Db -> DB

7d8dc71

Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>

remove melrunner from import

2578cf9

Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>

bragaigor dismissed diegoximenes’s stale review via 2578cf9 December 22, 2025 17:14

bragaigor force-pushed the braga/rename-arbdb-consensusdb branch from 45accf4 to 2578cf9 Compare December 22, 2025 17:14

bragaigor requested review from diegoximenes and pmikolajczyk41 December 22, 2025 17:21

diegoximenes approved these changes Dec 22, 2025

View reviewed changes

joshuacolvin0 added the design-approved label Dec 22, 2025

joshuacolvin0 added this pull request to the merge queue Dec 22, 2025

Merged via the queue into master with commit 1f915ab Dec 22, 2025
40 of 41 checks passed

joshuacolvin0 deleted the braga/rename-arbdb-consensusdb branch December 22, 2025 20:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rename database variable names #4155

Rename database variable names #4155

Uh oh!

bragaigor commented Dec 18, 2025 •

edited

Loading

Uh oh!

codecov bot commented Dec 18, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 18, 2025 •

edited

Loading

Uh oh!

diegoximenes left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pmikolajczyk41 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Rename database variable names #4155

Rename database variable names #4155

Uh oh!

Conversation

bragaigor commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ 2 Tests Failed:

Uh oh!

diegoximenes left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pmikolajczyk41 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

bragaigor commented Dec 18, 2025 •

edited

Loading

codecov bot commented Dec 18, 2025 •

edited

Loading

github-actions bot commented Dec 18, 2025 •

edited

Loading