[MEL] - Prevent MEL node startup if have non-MEL entries in ConsensusDB#4449
Merged
rauljordan merged 7 commits intomasterfrom Mar 23, 2026
Merged
[MEL] - Prevent MEL node startup if have non-MEL entries in ConsensusDB#4449rauljordan merged 7 commits intomasterfrom
rauljordan merged 7 commits intomasterfrom
Conversation
bragaigor
reviewed
Mar 2, 2026
Contributor
bragaigor
left a comment
bragaigor
left a comment
There was a problem hiding this comment.
LGTM, just a few minor comments
Contributor
❌ 11 Tests Failed:
View the top 3 failed tests by shortest run time
📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4449 +/- ##
==========================================
+ Coverage 34.54% 35.12% +0.58%
==========================================
Files 497 497
Lines 58907 58934 +27
==========================================
+ Hits 20347 20701 +354
+ Misses 34965 34550 -415
- Partials 3595 3683 +88 |
bragaigor
assigned
ganeshvanahalli and
diegoximenes and unassigned
bragaigor and
ganeshvanahalli
diegoximenes
previously approved these changes
Mar 6, 2026
eljobe
requested changes
Mar 9, 2026
Member
eljobe
left a comment
eljobe
left a comment
There was a problem hiding this comment.
Would it be prohibitively expensive to write some unit tests for this?
I think it would be great to be sure we have the right branches covered.
arbnode/node.go
Outdated
| return err | ||
| } | ||
| if hasDelayedMessageCountKey { | ||
| return errors.New("MEL being initialized when DB already has stale keys from inbox reader") |
Member
There was a problem hiding this comment.
It would be better if this error were distinguishable from the one on line 836 when we see them in a log. Like, it would be good to mention that this one found a stale DelayedMessageCountKey and the other one found a SequencerBatchCountKey.
Contributor
Author
There was a problem hiding this comment.
added the tests
eljobe
previously approved these changes
Mar 23, 2026
rauljordan
dismissed stale reviews from eljobe, diegoximenes, and bragaigor
The base branch was changed.
eljobe
approved these changes
Mar 23, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
rauljordan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes it that If the inbox tracker / reader have DB values (meaning a node was started in non-MEL mode), we should error on startup if we enable the MEL flag.
Resolves NIT-4571