Skip to content

backport: fix opening classic-msg database#4460

Merged
joshuacolvin0 merged 5 commits intov3.9.x-releasefrom
backport-v3.9.x-fix-opening-classic-msg
Mar 4, 2026
Merged

backport: fix opening classic-msg database#4460
joshuacolvin0 merged 5 commits intov3.9.x-releasefrom
backport-v3.9.x-fix-opening-classic-msg

Conversation

@magicxyyz
Copy link
Contributor

@magicxyyz magicxyyz commented Mar 4, 2026

fixes NIT-4603

backport #4065

@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2026

❌ 5 Tests Failed:

Tests completed Failed Passed Skipped
2172 5 2167 0
View the top 3 failed tests by shortest run time
TestVersion30
Stack Traces | 6.360s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
=== PAUSE TestVersion30
=== CONT  TestVersion30
    precompile_inclusion_test.go:90: goroutine 456619 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.7/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x40c35f0, 0xc068b0a380}, {0x4080f00, 0xc0367594a0}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/system_tests.Require(0xc068b0a380, {0x4080f00, 0xc0367594a0}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/system_tests/common_test.go:1790 +0x5d
        github.com/offchainlabs/nitro/system_tests.testPrecompiles(0xc068b0a380, 0x1e, {0xc07bbfbdb0, 0x6, 0xc033337c10?})
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:90 +0x371
        github.com/offchainlabs/nitro/system_tests.TestVersion30(0xc068b0a380?)
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:67 +0x798
        testing.tRunner(0xc068b0a380, 0x3d09728)
        	/opt/hostedtoolcache/go/1.25.7/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.7/x64/src/testing/testing.go:1997 +0x465
        
    precompile_inclusion_test.go:90: �[31;1m [] execution aborted (timeout = 5s) �[0;0m
--- FAIL: TestVersion30 (6.36s)
TestAuctioneerFailover_RapidRecovery
Stack Traces | 15.060s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
INFO [03-04|19:49:51.377] Imported new potential chain segment     number=15 hash=2d3b17..7050c0 blocks=1 txs=1 mgas=0.979 elapsed=1.172ms     mgasps=835.383  triediffs=37.33KiB triedirty=0.00B
INFO [03-04|19:49:51.377] Chain head was updated                   number=15 hash=2d3b17..7050c0 root=0a950e..562a97 elapsed="116.387µs"
    auctioneer_failover_test.go:45: 
        	Error Trace:	/home/runner/work/nitro/nitro/timeboost/auctioneer_failover_test.go:45
        	            				/home/runner/work/nitro/nitro/timeboost/auctioneer_failover_test.go:312
        	Error:      	Received unexpected error:
        	            	invalid length, need 256 bits
        	            	opening wallet
        	            	github.com/offchainlabs/nitro/timeboost.NewAuctioneerServer
        	            		/home/runner/work/nitro/nitro/timeboost/auctioneer.go:207
        	            	github.com/offchainlabs/nitro/timeboost.createAndStartAuctioneer
        	            		/home/runner/work/nitro/nitro/timeboost/auctioneer_failover_test.go:44
        	            	github.com/offchainlabs/nitro/timeboost.TestAuctioneerFailover_RapidRecovery
        	            		/home/runner/work/nitro/nitro/timeboost/auctioneer_failover_test.go:312
        	            	testing.tRunner
        	            		/opt/hostedtoolcache/go/1.25.7/x64/src/testing/testing.go:1934
        	            	runtime.goexit
        	            		/opt/hostedtoolcache/go/1.25.7/x64/src/runtime/asm_amd64.s:1693
        	Test:       	TestAuctioneerFailover_RapidRecovery
--- FAIL: TestAuctioneerFailover_RapidRecovery (15.06s)
TestBatchPosterActuallyPostsBlobsToL1
Stack Traces | 26.720s run time
=== RUN   TestBatchPosterActuallyPostsBlobsToL1
=== PAUSE TestBatchPosterActuallyPostsBlobsToL1
=== CONT  TestBatchPosterActuallyPostsBlobsToL1
    batch_poster_test.go:884: goroutine 53 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.7/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x40c35f0, 0xc000483180}, {0x4080a20, 0x5e98060}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/system_tests.Require(0xc000483180, {0x4080a20, 0x5e98060}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/system_tests/common_test.go:1790 +0x5d
        github.com/offchainlabs/nitro/system_tests.TestBatchPosterActuallyPostsBlobsToL1(0xc000483180)
        	/home/runner/work/nitro/nitro/system_tests/batch_poster_test.go:884 +0x388
        testing.tRunner(0xc000483180, 0x3d08660)
        	/opt/hostedtoolcache/go/1.25.7/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.7/x64/src/testing/testing.go:1997 +0x465
        
    batch_poster_test.go:884: �[31;1m [] context deadline exceeded �[0;0m
--- FAIL: TestBatchPosterActuallyPostsBlobsToL1 (26.72s)

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@magicxyyz magicxyyz changed the title backport: opening classic-msg database backport: fix opening classic-msg database Mar 4, 2026
@magicxyyz magicxyyz marked this pull request as ready for review March 4, 2026 20:29
Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshuacolvin0 joshuacolvin0 merged commit af73e7d into v3.9.x-release Mar 4, 2026
63 of 73 checks passed
@joshuacolvin0 joshuacolvin0 deleted the backport-v3.9.x-fix-opening-classic-msg branch March 4, 2026 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants