Skip to content

Reuse wasip1 implementation from caller-env#4473

Merged
pmikolajczyk41 merged 6 commits intozk-prove-any/sp1-runnerfrom
pmikolajczyk/nit-4618-wasip1
Mar 6, 2026
Merged

Reuse wasip1 implementation from caller-env#4473
pmikolajczyk41 merged 6 commits intozk-prove-any/sp1-runnerfrom
pmikolajczyk/nit-4618-wasip1

Conversation

@pmikolajczyk41
Copy link
Copy Markdown
Member

  1. Tiny cleanup in JIT wrapper syntax
  2. Delegate wasip1 stub function implementations to caller-env

closes NIT-4618

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 32.99%. Comparing base (bebced4) to head (dfbab75).
⚠️ Report is 7 commits behind head on zk-prove-any/sp1-runner.

Additional details and impacted files
@@                     Coverage Diff                     @@
##           zk-prove-any/sp1-runner    #4473      +/-   ##
===========================================================
+ Coverage                    32.81%   32.99%   +0.18%     
===========================================================
  Files                          493      493              
  Lines                        58290    58290              
===========================================================
+ Hits                         19127    19235     +108     
+ Misses                       35825    35720     -105     
+ Partials                      3338     3335       -3     

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 5, 2026

❌ 11 Tests Failed:

Tests completed Failed Passed Skipped
4299 11 4288 0
View the top 3 failed tests by shortest run time
TestDataStreaming_PositiveScenario/Many_senders,_long_messages
Stack Traces | 0.180s run time
=== RUN   TestDataStreaming_PositiveScenario/Many_senders,_long_messages
WARN [03-05|14:49:35.553] Served datastreaming_start               conn=127.0.0.1:36466 reqid=10 duration=37.468835ms err="we have already seen this request; aborting replayed protocol"
INFO [03-05|14:49:35.554] rpc response                             method=datastreaming_start logId=10 err="we have already seen this request; aborting replayed protocol" result={} attempt=0 args="[\"0x69a997ff\", \"0x30\", \"0xd9\", \"0x286d\", \"0xa\", \"0xf10d80807b639da4b188824293c2ea4a8ad4ae27de71dfe888b558a1bf337dbe5c785721eb5dd981e855bc83844518fc22aecf9ef74559bda3a717fbc5b2cf3500\"]" errorData=null
    protocol_test.go:230: goroutine 298 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.7/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x1569570, 0xc0002ecfc0}, {0x1550020, 0xc000e823c0}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/daprovider/data_streaming.testBasic.func1()
        	/home/runner/work/nitro/nitro/daprovider/data_streaming/protocol_test.go:230 +0x14f
        created by github.com/offchainlabs/nitro/daprovider/data_streaming.testBasic in goroutine 292
        	/home/runner/work/nitro/nitro/daprovider/data_streaming/protocol_test.go:223 +0x85
        
    protocol_test.go:230: �[31;1m [] we have already seen this request; aborting replayed protocol �[0;0m
--- FAIL: TestDataStreaming_PositiveScenario/Many_senders,_long_messages (0.18s)
TestDataStreaming_PositiveScenario
Stack Traces | 0.200s run time
=== RUN   TestDataStreaming_PositiveScenario
--- FAIL: TestDataStreaming_PositiveScenario (0.20s)
TestNitroNodeVersionAlerter
Stack Traces | 0.840s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
INFO [03-05|14:58:42.392] DataPoster sent transaction              nonce=6   hash=e633cb..077395 feeCap=2,490,038,670  tipCap=50,000,000    blobFeeCap=<nil> gas=161,046
INFO [03-05|14:58:42.392] BatchPoster: batch sent                  sequenceNumber=7  from=15 to=20 prevDelayed=4 currentDelayed=6  totalSegments=10 numBlobs=0
INFO [03-05|14:58:42.392] Starting work on payload                 id=0x0392dfc0e62d701f
INFO [03-05|14:58:42.394] Updated payload                          id=0x0392dfc0e62d701f number=64 hash=531524..dde303 txs=1  withdrawals=0 gas=21000      fees=0.002099255981 root=4fda35..a97691 elapsed=1.145ms
WARN [03-05|14:58:42.394] XClaimJustID returned empty response when indicating heartbeat msgID=1772722722219-0
INFO [03-05|14:58:42.395] Stopping work on payload                 id=0x0392dfc0e62d701f reason=delivery
INFO [03-05|14:58:42.397] Starting work on payload                 id=0x03807da23bb8e876
INFO [03-05|14:58:42.397] Imported new potential chain segment     number=64 hash=531524..dde303 blocks=1  txs=1  mgas=0.021  elapsed=2.849ms      mgasps=7.369    triediffs=312.34KiB triedirty=0.00B
INFO [03-05|14:58:42.397] Chain head was updated                   number=64 hash=531524..dde303 root=4fda35..a97691 elapsed="66.495µs"
INFO [03-05|14:58:42.398] Updated payload                          id=0x03807da23bb8e876 number=53 hash=a47a88..59d22b txs=1  withdrawals=0 gas=148,699    fees=7.43495e-06    root=025d0b..46d4b5 elapsed=1.275ms
INFO [03-05|14:58:42.399] Stopping work on payload                 id=0x03807da23bb8e876 reason=delivery
INFO [03-05|14:58:42.400] Opened ancient database                  database=/home/runner/work/nitro/nitro/target/tmp/deadbeefbee/TestPowInkUsage3222711449/001/test-stack-name/l2chaindata/ancient/chain readonly=false
INFO [03-05|14:58:42.400] Opened Era store                         datadir=/home/runner/work/nitro/nitro/target/tmp/deadbeefbee/TestPowInkUsage3222711449/001/test-stack-name/l2chaindata/ancient/chain/era
INFO [03-05|14:58:42.400] Using pebble as the backing database
INFO [03-05|14:58:42.400] Allocated cache and file handles         database=/home/runner/work/nitro/nitro/target/tmp/deadbeefbee/TestPowInkUsage3222711449/001/test-stack-name/wasm cache=16.00MiB handles=16
INFO [03-05|14:58:42.401] Imported new potential chain segment     number=53 hash=a47a88..59d22b blocks=1  txs=1  mgas=0.149  elapsed=2.438ms      mgasps=60.990   triediffs=262.38KiB triedirty=0.00B
INFO [03-05|14:58:42.401] Chain head was updated                   number=53 hash=a47a88..59d22b root=025d0b..46d4b5 elapsed="89.548µs"
INFO [03-05|14:58:42.401] Submitted transaction                    hash=0x155fa5663bb4b5c287195e15daaaeab2df55de494b5ad4718d9a03e1aeec853b from=0x26E554a8acF9003b83495c7f45F06edCB803d4e3 nonce=29  recipient=0x26E554a8acF9003b83495c7f45F06edCB803d4e3 value=1
WARN [03-05|14:58:42.401] Getting file info                        dir= error="stat : no such file or directory"
--- FAIL: TestNitroNodeVersionAlerter (0.84s)

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

Copy link
Copy Markdown
Contributor

@bragaigor bragaigor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great with the caveat that logic matches for the delegated calls, left a comment for that

Copy link
Copy Markdown
Contributor

@bragaigor bragaigor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bragaigor bragaigor assigned pmikolajczyk41 and unassigned bragaigor Mar 6, 2026
@pmikolajczyk41 pmikolajczyk41 merged commit c792fbf into zk-prove-any/sp1-runner Mar 6, 2026
21 checks passed
@pmikolajczyk41 pmikolajczyk41 deleted the pmikolajczyk/nit-4618-wasip1 branch March 6, 2026 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants