Add liveness and readiness endpoints to transaction-filterer by MishkaRogachev · Pull Request #4495 · OffchainLabs/nitro

MishkaRogachev · 2026-03-11T11:11:35Z

Adds /liveness and /readiness endpoints to the transaction-filterer using the existing geth HTTP server

MishkaRogachev · 2026-03-11T11:13:08Z

cmd/transaction-filterer/api/api.go

 	}}
 	stack.RegisterAPIs(apis)

+	stack.RegisterHandler("liveness", "/liveness", http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {


Note: requires http.vhosts configuration to allow pod IP

codecov · 2026-03-11T11:29:15Z

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 32.02%. Comparing base (522b71e) to head (1ea4010).
⚠️ Report is 192 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4495      +/-   ##
==========================================
- Coverage   32.15%   32.02%   -0.13%     
==========================================
  Files         495      495              
  Lines       58758    58764       +6     
==========================================
- Hits        18891    18817      -74     
- Misses      36476    36560      +84     
+ Partials     3391     3387       -4

github-actions · 2026-03-11T12:04:05Z

❌ 6 Tests Failed:

Tests completed	Failed	Passed	Skipped
4446	6	4440	0

View the top 3 failed tests by shortest run time

TestVersion30

Stack Traces | 11.590s run time

... [CONTENT TRUNCATED: Keeping last 20 lines]
        github.com/offchainlabs/nitro/system_tests.Require(0xc008360000, {0x40f5ae0, 0xc13aef6360}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/system_tests/common_test.go:2086 +0x5d
        github.com/offchainlabs/nitro/system_tests.testPrecompiles(0xc008360000, 0x1e, {0xc135563db0, 0x6, 0x0?})
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:94 +0x371
        github.com/offchainlabs/nitro/system_tests.TestVersion30(0xc008360000?)
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:67 +0x798
        testing.tRunner(0xc008360000, 0x3d69ba8)
        	/opt/hostedtoolcache/go/1.25.7/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.7/x64/src/testing/testing.go:1997 +0x465
        
    precompile_inclusion_test.go:94: �[31;1m [] execution aborted (timeout = 5s) �[0;0m
INFO [03-17|16:31:36.527] Submitted transaction                    hash=0x293c2caf3d8f4f701be549be4fc43e6740706187280ae0b546553ea010bf22d9 from=0x26E554a8acF9003b83495c7f45F06edCB803d4e3 nonce=0  recipient=0x0C709F340F0BB2e361229e345B7e26999d0969Ab value=1,000,000,000,000
INFO [03-17|16:31:36.527] InboxTracker                             sequencerBatchCount=4  messageCount=7  l1Block=38 l1Timestamp=2026-03-17T16:32:05+0000
INFO [03-17|16:31:36.528] Submitted transaction                    hash=0xa87cb9837abf569a5db6718d34764991eb9c6013ecb4ce3d03d32b17d4b93f13 from=0xb386a74Dcab67b66F8AC07B4f08365d37495Dd23 nonce=2  recipient=0x0fC2181A7Ff85dB6b1b3Fdd7D5c26FBB10c037F9 value=0
INFO [03-17|16:31:36.528] DataPoster sent transaction              nonce=2  hash=a87cb9..b93f13 feeCap=17,118,077,800 tipCap=50,000,000    blobFeeCap=&lt;nil&gt; gas=155,171
INFO [03-17|16:31:36.528] BatchPoster: batch sent                  sequenceNumber=3 from=6  to=9  prevDelayed=1 currentDelayed=3 totalSegments=5  numBlobs=0
INFO [03-17|16:31:36.529] Submitted transaction                    hash=0xd6cb1ad2fca24f61f8bdf8aacf09f69939110c3fda894c710c1a550425374c54 from=0x26E554a8acF9003b83495c7f45F06edCB803d4e3 nonce=9  recipient=0x26E554a8acF9003b83495c7f45F06edCB803d4e3 value=1
WARN [03-17|16:31:36.529] Served eth_call                          reqid=11  duration=7.122469623s err="execution aborted (timeout = 5s)"
--- FAIL: TestVersion30 (11.59s)

TestVersion40

Stack Traces | 11.610s run time

... [CONTENT TRUNCATED: Keeping last 20 lines]
INFO [03-17|16:31:36.539] Stopping work on payload                 id=0x03ad959e3f67347f reason=delivery
INFO [03-17|16:31:36.539] Updated payload                          id=0x03f7bc7143a152dd number=90 hash=927e2e..ff35f2 txs=1  withdrawals=0 gas=21000      fees=0.0020999771   root=57510c..d9ae4e elapsed=1.192ms
INFO [03-17|16:31:36.540] Stopping work on payload                 id=0x03f7bc7143a152dd reason=delivery
INFO [03-17|16:31:36.541] Submitted transaction                    hash=0xa56690e72f5d7b414a438130af77423a88943abddc7311a6f8d1b297de1e853b from=0x26E554a8acF9003b83495c7f45F06edCB803d4e3 nonce=15 recipient=0x0C709F340F0BB2e361229e345B7e26999d0969Ab value=1
INFO [03-17|16:31:36.541] Imported new potential chain segment     number=90 hash=927e2e..ff35f2 blocks=1  txs=1  mgas=0.021  elapsed=1.804ms     mgasps=11.635   triediffs=399.76KiB triedirty=0.00B
INFO [03-17|16:31:36.542] Chain head was updated                   number=90 hash=927e2e..ff35f2 root=57510c..d9ae4e elapsed="63.879µs"
INFO [03-17|16:31:36.542] Updated payload                          id=0x037bb18ede7b7de2 number=35 hash=a22f6c..9ea299 txs=1  withdrawals=0 gas=485,290    fees=2.42645e-05    root=1c4454..d66b41 elapsed=5.317ms
INFO [03-17|16:31:36.543] Imported new potential chain segment     number=36 hash=83c84e..d9860f blocks=1  txs=1  mgas=0.143  elapsed=9.017ms     mgasps=15.844   triediffs=182.14KiB triedirty=0.00B
INFO [03-17|16:31:36.543] Chain head was updated                   number=36 hash=83c84e..d9860f root=7e0578..0dc1b0 elapsed="98.324µs"
INFO [03-17|16:31:36.543] Submitted transaction                    hash=0x2149f2d9b1ecb02092c28bb8c387332de9eaf1dccf62cd95b233fada0aab541c from=0xaF24Ca6c2831f4d4F629418b50C227DF0885613A nonce=5  recipient=0xaF24Ca6c2831f4d4F629418b50C227DF0885613A value=1
WARN [03-17|16:31:36.542] Served eth_getTransactionReceipt         reqid=1   duration="25.627µs"   err="transaction indexing is in progress" errdata="\"transaction indexing is in progress\""
INFO [03-17|16:31:36.545] Stopping work on payload                 id=0x037bb18ede7b7de2 reason=delivery
INFO [03-17|16:31:36.546] Writing cached state to disk             block=1  hash=e576ee..4eedbd root=8448b4..050cee
INFO [03-17|16:31:36.546] Persisted trie from memory database      nodes=20  flushnodes=0 size=3.26KiB   flushsize=0.00B time="95.669µs"  flushtime=0s gcnodes=0 gcsize=0.00B gctime="1.564µs"  livenodes=0   livesize=0.00B
INFO [03-17|16:31:36.546] Writing cached state to disk             block=1  hash=e576ee..4eedbd root=8448b4..050cee
INFO [03-17|16:31:36.546] Persisted trie from memory database      nodes=0   flushnodes=0 size=0.00B     flushsize=0.00B time=771ns       flushtime=0s gcnodes=0 gcsize=0.00B gctime=0s         livenodes=0   livesize=0.00B
INFO [03-17|16:31:36.546] Writing snapshot state to disk           root=6b754c..7398ca
INFO [03-17|16:31:36.546] Persisted trie from memory database      nodes=0   flushnodes=0 size=0.00B     flushsize=0.00B time=401ns       flushtime=0s gcnodes=0 gcsize=0.00B gctime=0s         livenodes=0   livesize=0.00B
INFO [03-17|16:31:36.546] Blockchain stopped
--- FAIL: TestVersion40 (11.61s)

TestSequencerPriceAdjustsFrom2Gwei

Stack Traces | 24.010s run time

... [CONTENT TRUNCATED: Keeping last 20 lines]
WARN [03-17|18:25:09.167] Served eth_sendRawTransactionConditional reqid=59   duration=185.941218ms err="Storage slot value condition not met"
WARN [03-17|18:25:09.167] Served eth_sendRawTransactionConditional reqid=61   duration=185.666556ms err="Storage slot value condition not met"
WARN [03-17|18:25:09.167] Served eth_sendRawTransactionConditional reqid=62   duration=185.571712ms err="Storage slot value condition not met"
INFO [03-17|18:25:09.167] Submitted transaction                    hash=0xaca79d40bd7bc594040378747433a885a3b971a293469c826a8a9b49ae3d3e39 from=0x705B8D7A939Ab492dc45f3AA9Ec9652f046e3fdd nonce=0   recipient=0x3a0a61C11D96F5B8c1492bEaA5bDAedefFff15E8 value=0
WARN [03-17|18:25:09.167] Served eth_sendRawTransactionConditional reqid=64   duration=185.23649ms  err="Storage slot value condition not met"
WARN [03-17|18:25:09.167] Served eth_sendRawTransactionConditional reqid=65   duration=185.102628ms err="Storage slot value condition not met"
WARN [03-17|18:25:09.167] Served eth_sendRawTransactionConditional reqid=66   duration=185.076786ms err="Storage slot value condition not met"
INFO [03-17|18:25:09.167] Starting peer-to-peer node               instance=test-stack-name/linux-amd64/go1.25.8
WARN [03-17|18:25:09.167] P2P server will be useless, neither dialing nor listening
INFO [03-17|18:25:09.168] Stopping work on payload                 id=0x0346709662b0f258 reason=delivery
INFO [03-17|18:25:09.168] Submitted transaction                    hash=0xf9300886d4057e9bb97c2d5bc71a7cd76662fee7a34e5ef13cd6255c0a15f678 from=0xaF24Ca6c2831f4d4F629418b50C227DF0885613A nonce=60  recipient=0xaF24Ca6c2831f4d4F629418b50C227DF0885613A value=1
WARN [03-17|18:25:09.171] Getting file info                        dir= error="stat : no such file or directory"
--- FAIL: TestSequencerPriceAdjustsFrom2Gwei (24.01s)
INFO [03-17|18:25:09.241] New Key                                  name=Faucet              Address=0xaF24Ca6c2831f4d4F629418b50C227DF0885613A
INFO [03-17|18:25:09.242] New Key                                  name=RollupOwner         Address=0x57Ff0F473737a1c161bfF9efDF016F7991585088
INFO [03-17|18:25:09.242] New Key                                  name=Sequencer           Address=0xb386a74Dcab67b66F8AC07B4f08365d37495Dd23
INFO [03-17|18:25:09.242] New Key                                  name=Validator           Address=0x83FFCFaCE2Fb0E1286686815503608A16EF41e47
INFO [03-17|18:25:09.242] New Key                                  name=User                Address=0x7E23C8862920797d81916d62c274dd9217113e28
INFO [03-17|18:25:09.242] Allocated trie memory caches             clean=154.00MiB dirty=256.00MiB
INFO [03-17|18:25:09.242] State schema set to default              scheme=path

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

cmd/transaction-filterer/api/api.go

…adiness-check-to-tx-filterer

…terer

joshuacolvin0

LGTM

Add liveness and readiness endpoints to transaction-filterer

2c51141

MishkaRogachev requested review from diegoximenes and tsahee March 11, 2026 11:11

MishkaRogachev assigned diegoximenes Mar 11, 2026

MishkaRogachev commented Mar 11, 2026

View reviewed changes

diegoximenes requested changes Mar 11, 2026

View reviewed changes

cmd/transaction-filterer/api/api.go Outdated Show resolved Hide resolved

diegoximenes assigned MishkaRogachev and unassigned diegoximenes Mar 11, 2026

MishkaRogachev added 2 commits March 16, 2026 17:43

Merge remote-tracking branch 'origin/master' into add-liveness-and-re…

1815589

…adiness-check-to-tx-filterer

TransactionFiltererAPI: simplify readiness endpoint

9f63423

MishkaRogachev assigned diegoximenes and unassigned MishkaRogachev Mar 16, 2026

MishkaRogachev requested a review from diegoximenes March 16, 2026 16:59

diegoximenes approved these changes Mar 17, 2026

View reviewed changes

diegoximenes assigned joshuacolvin0 and unassigned diegoximenes Mar 17, 2026

Merge branch 'master' into add-liveness-and-readiness-check-to-tx-fil…

1ea4010

…terer

joshuacolvin0 reviewed Mar 20, 2026

View reviewed changes

joshuacolvin0 added the design-approved label Mar 20, 2026

joshuacolvin0 enabled auto-merge March 20, 2026 04:34

joshuacolvin0 added this pull request to the merge queue Mar 20, 2026

Merged via the queue into master with commit d96d6d1 Mar 20, 2026
42 of 43 checks passed

joshuacolvin0 deleted the add-liveness-and-readiness-check-to-tx-filterer branch March 20, 2026 05:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add liveness and readiness endpoints to transaction-filterer#4495

Add liveness and readiness endpoints to transaction-filterer#4495
joshuacolvin0 merged 4 commits intomasterfrom
add-liveness-and-readiness-check-to-tx-filterer

MishkaRogachev commented Mar 11, 2026

Uh oh!

MishkaRogachev Mar 11, 2026

Uh oh!

codecov bot commented Mar 11, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 11, 2026 •

edited

Loading

Uh oh!

Uh oh!

joshuacolvin0 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

MishkaRogachev commented Mar 11, 2026

Uh oh!

MishkaRogachev Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ 6 Tests Failed:

Uh oh!

Uh oh!

joshuacolvin0 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Mar 11, 2026 •

edited

Loading

github-actions bot commented Mar 11, 2026 •

edited

Loading