Disable cranelift fallback for non-onchain execution modes#4541
Merged
Disable cranelift fallback for non-onchain execution modes#4541
Conversation
Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4541 +/- ##
==========================================
- Coverage 34.54% 34.52% -0.02%
==========================================
Files 497 497
Lines 58907 58936 +29
==========================================
Hits 20347 20347
- Misses 34965 34985 +20
- Partials 3595 3604 +9 |
Contributor
❌ 10 Tests Failed:
View the top 3 failed tests by shortest run time
📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
tsahee
requested changes
Mar 23, 2026
arbos/programs/native.go
Outdated
| suppliedGas := burner.GasLeft() | ||
| gasLeft := suppliedGas | ||
| info, asmMap, err := activateProgramInternal(program, codehash, wasm, page_limit, stylusVersion, arbosVersionForGas, debug, &gasLeft, runCtx.WasmTargets(), moduleActivationMandatory) | ||
| shouldAllowFallback := allowFallback.Load() && !runCtx.IsEthcall() |
Contributor
There was a problem hiding this comment.
disable for anything unless IsExecutedOnChain()
Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
allowFallbackis enabled globally and LLVM compilation fails,activateProgramInternalfalls back to cranelift. This PR disables such fallback for non-onchain execution modesCloses NIT-4697