Allow collecting tips in arbos: follow up

[pmikolajczyk41]

Resolve comments from #4515:

• Allow collecting tips in arbos #4515 (comment)
• Allow collecting tips in arbos #4515 (comment)

---

Related to NIT-4659

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 34.50%. Comparing base (3751444) to head (bad0c59).
⚠️ Report is 17 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4558      +/-   ##
==========================================
- Coverage   34.50%   34.50%   -0.01%     
==========================================
  Files         497      497              
  Lines       58978    58980       +2     
==========================================
- Hits        20353    20350       -3     
- Misses      35012    35015       +3     
- Partials     3613     3615       +2     

[github-actions]

❌ 11 Tests Failed:

Tests completed	Failed	Passed	Skipped
4547	11	4536	0

View the top 3 failed tests by shortest run time

TestPruningDBSizeReduction

Stack Traces | 0.000s run time

=== RUN   TestPruningDBSizeReduction
--- FAIL: TestPruningDBSizeReduction (0.00s)

TestAliasingFlaky

Stack Traces | -0.000s run time

... [CONTENT TRUNCATED: Keeping last 20 lines]
INFO [03-25|08:33:11.087] Writing cached state to disk             block=1  hash=37e184..9098f7 root=c349f6..9b02e2
INFO [03-25|08:33:11.087] Persisted trie from memory database      nodes=23  flushnodes=0 size=4.32KiB  flushsize=0.00B time="59.19µs"   flushtime=0s gcnodes=0 gcsize=0.00B gctime=0s         livenodes=69   livesize=12.78KiB
INFO [03-25|08:33:11.087] Writing snapshot state to disk           root=77ae46..2fbcae
INFO [03-25|08:33:11.087] Persisted trie from memory database      nodes=0   flushnodes=0 size=0.00B    flushsize=0.00B time=721ns       flushtime=0s gcnodes=0 gcsize=0.00B gctime=0s         livenodes=69   livesize=12.78KiB
INFO [03-25|08:33:11.087] Starting work on payload                 id=0x03fdcc24dadc7d31
INFO [03-25|08:33:11.087] Blockchain stopped
INFO [03-25|08:33:11.087] Submitted transaction                    hash=0x9bcb54c9b95b181b29a072230f55d61f11c4da6e5ccb972e910b0984c111ddd4 from=0xb386a74Dcab67b66F8AC07B4f08365d37495Dd23 nonce=4  recipient=0x0C92F53624C742b8CdcE2047A3ee61CeD99c68C5 value=0
INFO [03-25|08:33:11.087] Ethereum protocol stopped
INFO [03-25|08:33:11.087] Transaction pool stopped
INFO [03-25|08:33:11.087] Persisting dirty state                   head=34 root=eba819..d11fee layers=34
INFO [03-25|08:33:11.087] Updated payload                          id=0x03fdcc24dadc7d31                      number=48 hash=b45fba..381257 txs=1  withdrawals=0 gas=21000     fees=0.002093792676 root=26c897..c676fb elapsed="306.186µs"
INFO [03-25|08:33:11.087] Starting work on payload                 id=0x03fb7cce099e1a2a
INFO [03-25|08:33:11.087] Stopping work on payload                 id=0x03fdcc24dadc7d31                      reason=delivery
INFO [03-25|08:33:11.088] Imported new potential chain segment     number=48 hash=b45fba..381257 blocks=1  txs=1  mgas=0.021 elapsed="448.661µs" mgasps=46.806   triediffs=230.44KiB triedirty=0.00B
INFO [03-25|08:33:11.088] Chain head was updated                   number=48 hash=b45fba..381257 root=26c897..c676fb elapsed="40.015µs"
INFO [03-25|08:33:11.088] Persisted dirty state to disk            size=167.74KiB elapsed="937.903µs"
INFO [03-25|08:33:11.088] Blockchain stopped
INFO [03-25|08:33:11.089] Updated payload                          id=0x03fb7cce099e1a2a                      number=35 hash=4001b6..dd7ace txs=1  withdrawals=0 gas=2,820,970 fees=0.0001410485   root=ad3a23..2488e6 elapsed=1.425ms
WARN [03-25|08:33:11.089] Error performing sealing work            err="chain rewind interrupted calculation of finalized block hash"
INFO [03-25|08:33:11.089] Stopping work on payload                 id=0x03fb7cce099e1a2a                      reason=delivery

TestBatchPosterL1SurplusMatchesBatchGasFlaky

Stack Traces | 0.550s run time

... [CONTENT TRUNCATED: Keeping last 20 lines]
panic: runtime error: invalid memory address or nil pointer dereference [recovered, repanicked]
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x2076b72]

goroutine 68 [running]:
testing.tRunner.func1.2({0x37d7fc0, 0x61dd9b0})
	/opt/hostedtoolcache/go/1.25.8/x64/src/testing/testing.go:1872 +0x237
testing.tRunner.func1()
	/opt/hostedtoolcache/go/1.25.8/x64/src/testing/testing.go:1875 +0x35b
panic({0x37d7fc0?, 0x61dd9b0?})
	/opt/hostedtoolcache/go/1.25.8/x64/src/runtime/panic.go:783 +0x132
github.com/offchainlabs/nitro/arbnode.(*InboxTracker).GetBatchCount(0x14775900?)
	/home/runner/work/nitro/nitro/arbnode/inbox_tracker.go:210 +0x12
github.com/offchainlabs/nitro/arbnode.(*InboxTracker).FindInboxBatchContainingMessage(0x0, 0x7)
	/home/runner/work/nitro/nitro/arbnode/inbox_tracker.go:225 +0x2f
github.com/offchainlabs/nitro/system_tests.TestBatchPosterL1SurplusMatchesBatchGasFlaky(0xc0002c3a40)
	/home/runner/work/nitro/nitro/system_tests/batch_poster_test.go:838 +0x725
testing.tRunner(0xc0002c3a40, 0x41a7920)
	/opt/hostedtoolcache/go/1.25.8/x64/src/testing/testing.go:1934 +0xea
created by testing.(*T).Run in goroutine 1
	/opt/hostedtoolcache/go/1.25.8/x64/src/testing/testing.go:1997 +0x465

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

[tsahee]

LGTM