Remove floats from util/arbmath

[pmikolajczyk41]

... and move them to a new package floatmath. No STF code was affected ✅

closes NIT-4707

[codecov]

Codecov Report

❌ Patch coverage is 65.21739% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 34.50%. Comparing base (3751444) to head (917a3b6).
⚠️ Report is 45 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4561      +/-   ##
==========================================
- Coverage   34.50%   34.50%   -0.01%     
==========================================
  Files         497      498       +1     
  Lines       58978    58967      -11     
==========================================
- Hits        20353    20346       -7     
+ Misses      35012    35006       -6     
- Partials     3613     3615       +2     

[github-actions]

❌ 11 Tests Failed:

Tests completed	Failed	Passed	Skipped
4553	11	4542	0

View the top 3 failed tests by shortest run time

TestPruningDBSizeReduction

Stack Traces | 0.000s run time

=== RUN   TestPruningDBSizeReduction
--- FAIL: TestPruningDBSizeReduction (0.00s)

TestAliasingFlaky

Stack Traces | -0.000s run time

... [CONTENT TRUNCATED: Keeping last 20 lines]
INFO [03-25|13:18:10.945] Updated payload                          id=0x039ccc8012d33816                      number=1 hash=b9e7ee..575e00 txs=1  withdrawals=0 gas=854,353 fees=8.54353e-07 root=a9ea19..788177 elapsed="277.999µs"
INFO [03-25|13:18:10.945] Stopping work on payload                 id=0x039ccc8012d33816                      reason=delivery
INFO [03-25|13:18:10.946] Imported new potential chain segment     number=1 hash=b9e7ee..575e00 blocks=1  txs=1  mgas=0.854 elapsed="515.57µs"  mgasps=1657.104 triediffs=3.08KiB triedirty=0.00B
INFO [03-25|13:18:10.946] Chain head was updated                   number=1 hash=b9e7ee..575e00 root=a9ea19..788177 elapsed="151.784µs"
INFO [03-25|13:18:10.946] Indexed transactions                     blocks=2  txs=1  tail=0 elapsed="53.139µs"
INFO [03-25|13:18:10.948] Deploying rollup creator
INFO [03-25|13:18:10.948] Deploying bridge creator contracts
INFO [03-25|13:18:10.948] Deploying bridge template
INFO [03-25|13:18:10.950] Submitted contract creation              hash=0x61f78ed7484d562ec25d752a5b868d87786cc5c21bd3482b81469d671a2b4197 from=0x57Ff0F473737a1c161bfF9efDF016F7991585088 nonce=1  contract=0xC0d44eBf2024FAa79d5aa2F2b1a19329E53a8a77 value=0
INFO [03-25|13:18:10.950] Starting peer-to-peer node               instance=test-stack-name/linux-amd64/go1.25.8
WARN [03-25|13:18:10.950] P2P server will be useless, neither dialing nor listening
INFO [03-25|13:18:10.950] Starting work on payload                 id=0x03cbdc9e246909e5
INFO [03-25|13:18:10.951] Updated payload                          id=0x03cbdc9e246909e5                      number=2 hash=94b3b9..17d4f0 txs=1  withdrawals=0 gas=1,501,105 fees=1.501105e-06 root=5a4b8d..13f30b elapsed="302.616µs"
INFO [03-25|13:18:10.951] Stopping work on payload                 id=0x03cbdc9e246909e5                      reason=delivery
INFO [03-25|13:18:10.951] Imported new potential chain segment     number=2 hash=94b3b9..17d4f0 blocks=1  txs=1  mgas=1.501 elapsed="438.821µs" mgasps=3420.768 triediffs=6.09KiB triedirty=0.00B
INFO [03-25|13:18:10.951] Chain head was updated                   number=2 hash=94b3b9..17d4f0 root=5a4b8d..13f30b elapsed="124.723µs"
INFO [03-25|13:18:10.952] New local node record                    seq=1,774,444,690,952 id=7d05988758e3ee6a                        ip=127.0.0.1 udp=0 tcp=0
INFO [03-25|13:18:10.952] Started P2P networking                   self=enode://6b38175e8cd779428bd69c36236613e69d800463f5b6da6c402a391c5d9663242e48fe6acd3b9eaa6f06b4b89523a89a3248df94ceed0735fdc8ffbc60b9489e@127.0.0.1:0
INFO [03-25|13:18:10.952] Started log indexer
WARN [03-25|13:18:10.952] Getting file info                        dir= error="stat : no such file or directory"

TestBatchPosterL1SurplusMatchesBatchGasFlaky

Stack Traces | 0.540s run time

... [CONTENT TRUNCATED: Keeping last 20 lines]
panic: runtime error: invalid memory address or nil pointer dereference [recovered, repanicked]
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x2076cb2]

goroutine 44 [running]:
testing.tRunner.func1.2({0x37d7fc0, 0x61dd9b0})
	/opt/hostedtoolcache/go/1.25.8/x64/src/testing/testing.go:1872 +0x237
testing.tRunner.func1()
	/opt/hostedtoolcache/go/1.25.8/x64/src/testing/testing.go:1875 +0x35b
panic({0x37d7fc0?, 0x61dd9b0?})
	/opt/hostedtoolcache/go/1.25.8/x64/src/runtime/panic.go:783 +0x132
github.com/offchainlabs/nitro/arbnode.(*InboxTracker).GetBatchCount(0x21f7900?)
	/home/runner/work/nitro/nitro/arbnode/inbox_tracker.go:210 +0x12
github.com/offchainlabs/nitro/arbnode.(*InboxTracker).FindInboxBatchContainingMessage(0x0, 0x7)
	/home/runner/work/nitro/nitro/arbnode/inbox_tracker.go:225 +0x2f
github.com/offchainlabs/nitro/system_tests.TestBatchPosterL1SurplusMatchesBatchGasFlaky(0xc00010b340)
	/home/runner/work/nitro/nitro/system_tests/batch_poster_test.go:838 +0x725
testing.tRunner(0xc00010b340, 0x41a7920)
	/opt/hostedtoolcache/go/1.25.8/x64/src/testing/testing.go:1934 +0xea
created by testing.(*T).Run in goroutine 1
	/opt/hostedtoolcache/go/1.25.8/x64/src/testing/testing.go:1997 +0x465

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

[gligneul]

Nice

[tsahee]

LGTM