Add Stylus redeem filtering tests: execution rollback NIT-4607#4564
Merged
Add Stylus redeem filtering tests: execution rollback NIT-4607#4564
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4564 +/- ##
==========================================
- Coverage 34.50% 34.47% -0.04%
==========================================
Files 497 498 +1
Lines 58978 59094 +116
==========================================
+ Hits 20353 20372 +19
- Misses 35012 35081 +69
- Partials 3613 3641 +28 |
Contributor
❌ 17 Tests Failed:
View the top 3 failed tests by shortest run time
📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds new system test coverage to ensure redeem filtering group rollback behaves correctly when the redeem chain involves Stylus (WASM) contracts, including both same-block “sandwich” scenarios and delayed inbox halt/resume scenarios (NIT-4607).
Changes:
- Add two new Stylus-focused system tests covering rollback isolation within a block and delayed sequencer halt/resume behavior.
- Add helper routines to enable Stylus (chain ownership + ink price) and deploy a Stylus storage contract for the tests.
- Add a changelog entry documenting the internal test additions.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| system_tests/retryable_tickets_filtering_stylus_test.go | New system tests validating redeem filtering rollback behavior with Stylus contracts (same-block and delayed-inbox variants). |
| changelog/mnasr-nit-4607.md | Notes the addition of Stylus redeem-related tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
diegoximenes
requested changes
Mar 27, 2026
diegoximenes
requested changes
Mar 31, 2026
diegoximenes
approved these changes
Apr 1, 2026
tsahee
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add system tests for Stylus contract redeem filtering (NIT-4607). Verifies that the group rollback mechanism
from PR #4436 correctly handles Stylus (WASM) contracts. Two tests: SandwichRollback (L2 same-block sandwich via Pause/Activate), DelayedSandwichRollback (L1 delayed inbox halt/resume cycle).