Skip to content

Add cmd/filtering-report binary with liveness/readiness endpoints - NIT-4766#4606

Merged
joshuacolvin0 merged 2 commits intoadd-filter-set-id-hashstorefrom
create-new-deployment-for-reporting
Apr 8, 2026
Merged

Add cmd/filtering-report binary with liveness/readiness endpoints - NIT-4766#4606
joshuacolvin0 merged 2 commits intoadd-filter-set-id-hashstorefrom
create-new-deployment-for-reporting

Conversation

@mahdy-nasr
Copy link
Copy Markdown
Contributor

Closes NIT-4766.

  • New cmd/filtering-report binary scaffolded similarly to cmd/transaction-filterer
  • Includes /liveness and /readiness HTTP health check endpoints

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2026

Codecov Report

❌ Patch coverage is 0% with 85 lines in your changes missing coverage. Please review.
✅ Project coverage is 33.96%. Comparing base (45c5342) to head (dabe6cb).
⚠️ Report is 3 commits behind head on add-filter-set-id-hashstore.

Additional details and impacted files
@@                       Coverage Diff                       @@
##           add-filter-set-id-hashstore    #4606      +/-   ##
===============================================================
- Coverage                        34.15%   33.96%   -0.20%     
===============================================================
  Files                              495      497       +2     
  Lines                            59057    59142      +85     
===============================================================
- Hits                             20170    20086      -84     
- Misses                           35330    35493     +163     
- Partials                          3557     3563       +6     

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

❌ 6 Tests Failed:

Tests completed Failed Passed Skipped
4804 6 4798 0
View the top 3 failed tests by shortest run time
TestAliasingFlaky
Stack Traces | -0.000s run time
=== RUN   TestAliasingFlaky
=== PAUSE TestAliasingFlaky
=== CONT  TestAliasingFlaky
    common_test.go:777: BuildL1 deployConfig: DeployBold=true, DeployReferenceDAContracts=false
INFO [04-07|17:34:46.585] Started P2P networking                   self=enode://cfad251275aa8e055bf410b0bde44b6464679ebf579df5f3035b33a2c8d956b1fa11c0e8c20b6e8503f06aae09ab139c82f939cde94c55db18dffe280993c014@127.0.0.1:0
WARN [04-07|17:34:46.585] Getting file info                        dir= error="stat : no such file or directory"
INFO [04-07|17:34:46.585] Started log indexer
TestBatchPosterL1SurplusMatchesBatchGasFlaky
Stack Traces | 0.540s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
panic: runtime error: invalid memory address or nil pointer dereference [recovered, repanicked]
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x2080db2]

goroutine 69 [running]:
testing.tRunner.func1.2({0x37ef720, 0x62109b0})
	/opt/hostedtoolcache/go/1.25.8/x64/src/testing/testing.go:1872 +0x237
testing.tRunner.func1()
	/opt/hostedtoolcache/go/1.25.8/x64/src/testing/testing.go:1875 +0x35b
panic({0x37ef720?, 0x62109b0?})
	/opt/hostedtoolcache/go/1.25.8/x64/src/runtime/panic.go:783 +0x132
github.com/offchainlabs/nitro/arbnode.(*InboxTracker).GetBatchCount(0x1f11b900?)
	/home/runner/work/nitro/nitro/arbnode/inbox_tracker.go:210 +0x12
github.com/offchainlabs/nitro/arbnode.(*InboxTracker).FindInboxBatchContainingMessage(0x0, 0x7)
	/home/runner/work/nitro/nitro/arbnode/inbox_tracker.go:225 +0x2f
github.com/offchainlabs/nitro/system_tests.TestBatchPosterL1SurplusMatchesBatchGasFlaky(0xc0002c3880)
	/home/runner/work/nitro/nitro/system_tests/batch_poster_test.go:839 +0x725
testing.tRunner(0xc0002c3880, 0x41c3538)
	/opt/hostedtoolcache/go/1.25.8/x64/src/testing/testing.go:1934 +0xea
created by testing.(*T).Run in goroutine 1
	/opt/hostedtoolcache/go/1.25.8/x64/src/testing/testing.go:1997 +0x465
TestParentChainEthConfigForkTransition
Stack Traces | 27.420s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
INFO [04-07|17:50:09.118] Updated payload                          id=0x0373908b7c16a567 number=40   hash=c0760f..f66696 txs=1   withdrawals=0 gas=142,082    fees=7.1041e-06     root=9455b9..4a14cc elapsed=8.753ms
INFO [04-07|17:50:09.122] Imported new potential chain segment     number=177  hash=458c7f..499f08 blocks=1  txs=1   mgas=0.021  elapsed=15.236ms     mgasps=1.378    triediffs=646.85KiB  triedirty=62.46KiB
INFO [04-07|17:50:09.122] Chain head was updated                   number=177  hash=458c7f..499f08 root=d8c5bc..8df237 elapsed="76.093µs"
INFO [04-07|17:50:09.124] Stopping work on payload                 id=0x0373908b7c16a567 reason=delivery
INFO [04-07|17:50:09.127] ExecutionEngine: Added DelayedMessages   msgIdx=106 delayedMsgIdx=4   block-header="&{ParentHash:0xaa979ce393bfd25a2f33d58dfd8e8f54d0bf4d7bfb884b3a19c720963be590f0 UncleHash:0x1dcc4de8dec75d7aab85b567b6ccd41ad312451b948a7413f0a142fd40d49347 Coinbase:0x8BF25db44C2084140F874D173e93F2F228cfEaC8 Root:0xe591a86148ade5bc259b5d3febf22b092d469a8b8281227b6644c4e7efbfb94a TxHash:0xb7b82bdb424aa82172ac866b3aeb0f549a30b79847c737e43535a3bf8669244d ReceiptHash:0xf08cf5553e1dae52e3df19b356b8320e17c39fb055f635739c31052db5c3e45e Bloom:[0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0] Difficulty:+1 Number:+106 GasLimit:1125899906842624 GasUsed:0 Time:1775584206 Extra:[0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0] MixDigest:0x0000000000000000000000000000002b00000000000000330000000000000000 Nonce:[0 0 0 0 0 0 0 5] BaseFee:+100000000 WithdrawalsHash:<nil> BlobGasUsed:<nil> ExcessBlobGas:<nil> ParentBeaconRoot:<nil> RequestsHash:<nil>}"
INFO [04-07|17:50:09.128] Imported new potential chain segment     number=40   hash=c0760f..f66696 blocks=1  txs=1   mgas=0.142  elapsed=9.120ms      mgasps=15.579   triediffs=199.79KiB  triedirty=0.00B
INFO [04-07|17:50:09.128] Chain head was updated                   number=40   hash=c0760f..f66696 root=9455b9..4a14cc elapsed="146.665µs"
INFO [04-07|17:50:09.134] ExecutionEngine: Added DelayedMessages   msgIdx=107 delayedMsgIdx=5   block-header="&{ParentHash:0xadb2298de3b991f3b068069bb245071dd9a236a46fae47d5c9a6aac8a65e088e UncleHash:0x1dcc4de8dec75d7aab85b567b6ccd41ad312451b948a7413f0a142fd40d49347 Coinbase:0x8BF25db44C2084140F874D173e93F2F228cfEaC8 Root:0x7e631149fa4b6e7f153ec6de81e62b3471b4781f724be749d1d00b4754c47f8d TxHash:0xb4f54ebc31fd0340da9b80e54454bdca9dd271078105137ca8da41d3429f1ce6 ReceiptHash:0xf08cf5553e1dae52e3df19b356b8320e17c39fb055f635739c31052db5c3e45e Bloom:[0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0] Difficulty:+1 Number:+107 GasLimit:1125899906842624 GasUsed:0 Time:1775584208 Extra:[0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0] MixDigest:0x0000000000000000000000000000002d00000000000000330000000000000000 Nonce:[0 0 0 0 0 0 0 6] BaseFee:+100000000 WithdrawalsHash:<nil> BlobGasUsed:<nil> ExcessBlobGas:<nil> ParentBeaconRoot:<nil> RequestsHash:<nil>}"
INFO [04-07|17:50:09.137] ExecutionEngine: Added DelayedMessages   msgIdx=108 delayedMsgIdx=6   block-header="&{ParentHash:0x470b751db1ec8d543cdc6e99fa28fa4592d547327f98b9709acfb742d2e74172 UncleHash:0x1dcc4de8dec75d7aab85b567b6ccd41ad312451b948a7413f0a142fd40d49347 Coinbase:0x8BF25db44C2084140F874D173e93F2F228cfEaC8 Root:0xbe7f94f66bc8fa42eeebb8af24b6336a99e2df02dfcd7e79bd240d595a30c156 TxHash:0x2d5096370b5b4ef5144c673b00d8331f84636ff43001f5911b81309dbc61c347 ReceiptHash:0xf08cf5553e1dae52e3df19b356b8320e17c39fb055f635739c31052db5c3e45e Bloom:[0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0] Difficulty:+1 Number:+108 GasLimit:1125899906842624 GasUsed:0 Time:1775584209 Extra:[0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0] MixDigest:0x0000000000000000000000000000002e00000000000000330000000000000000 Nonce:[0 0 0 0 0 0 0 7] BaseFee:+100000000 WithdrawalsHash:<nil> BlobGasUsed:<nil> ExcessBlobGas:<nil> ParentBeaconRoot:<nil> RequestsHash:<nil>}"
INFO [04-07|17:50:09.138] Submitted transaction                    hash=0x476fa88e2e9aaf25ae1609b87adb1a6dbcd953d8e8062ae0c6496b3ed8b700d3 from=0x2747d76087f5386Ed402f7E47b5Eac5e11DA73A6 nonce=0   recipient=0x0000000000000000000000000000000000000074 value=0
INFO [04-07|17:50:09.140] Updated payload                          id=0x03d6cd883096a1ac number=27   hash=f19cf5..e28c13 txs=1   withdrawals=0 gas=7,088,538  fees=7.088538e-06   root=dcc8ce..de3649 elapsed=22.081ms
INFO [04-07|17:50:09.152] Stopping work on payload                 id=0x03d6cd883096a1ac reason=delivery
INFO [04-07|17:50:09.157] Submitted transaction                    hash=0x59106d882e92f348f494c02fba8b8882ee0cd4a30fb99c28d25ad43bb6202757 from=0xaF24Ca6c2831f4d4F629418b50C227DF0885613A nonce=0   recipient=0x0C709F340F0BB2e361229e345B7e26999d0969Ab value=1,000,000,000,000
INFO [04-07|17:50:09.159] created block                            l2Block=4   l2BlockHash=976382..9380ab
INFO [04-07|17:50:09.163] ExecutionEngine: Added DelayedMessages   msgIdx=109 delayedMsgIdx=7   block-header="&{ParentHash:0xc364fe29767af55242d028fa0485c37643f6afb2e472b7cacfa5fd848bdd6120 UncleHash:0x1dcc4de8dec75d7aab85b567b6ccd41ad312451b948a7413f0a142fd40d49347 Coinbase:0x8BF25db44C2084140F874D173e93F2F228cfEaC8 Root:0x2c06d55416256cbdc349d6ff4ac08a1d549934cc8bc582f10fac96d9fca57f21 TxHash:0xd2d3dfc6d85d5f1e2a62da1171de361608ead96e7d5608cbec9cb5f6ae2f508b ReceiptHash:0xf08cf5553e1dae52e3df19b356b8320e17c39fb055f635739c31052db5c3e45e Bloom:[0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0] Difficulty:+1 Number:+109 GasLimit:1125899906842624 GasUsed:0 Time:1775584211 Extra:[0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0] MixDigest:0x0000000000000000000000000000003000000000000000330000000000000000 Nonce:[0 0 0 0 0 0 0 8] BaseFee:+100000000 WithdrawalsHash:<nil> BlobGasUsed:<nil> ExcessBlobGas:<nil> ParentBeaconRoot:<nil> RequestsHash:<nil>}"
INFO [04-07|17:50:09.164] Starting peer-to-peer node               instance=test-stack-name/linux-amd64/go1.25.8
WARN [04-07|17:50:09.164] P2P server will be useless, neither dialing nor listening
INFO [04-07|17:50:09.166] Starting peer-to-peer node               instance=test-stack-name/linux-amd64/go1.25.8
WARN [04-07|17:50:09.166] P2P server will be useless, neither dialing nor listening
WARN [04-07|17:50:09.166] Getting file info                        dir= error="stat : no such file or directory"

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

Comment thread cmd/filtering-report/api/api.go Outdated
Comment thread execution/gethexec/filtering_report_client.go
@mahdy-nasr mahdy-nasr force-pushed the create-new-deployment-for-reporting branch from 2364559 to dabe6cb Compare April 7, 2026 17:20
@mahdy-nasr mahdy-nasr changed the base branch from master to add-filter-set-id-hashstore April 7, 2026 18:31
@mahdy-nasr mahdy-nasr assigned diegoximenes and unassigned mahdy-nasr Apr 7, 2026
Copy link
Copy Markdown
Contributor

@diegoximenes diegoximenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mahdy-nasr Since we are starting to work with stacked PRs in this effort, let's avoid force pushing on branches that have a related PR.

@joshuacolvin0 joshuacolvin0 merged commit c238364 into add-filter-set-id-hashstore Apr 8, 2026
25 of 26 checks passed
@joshuacolvin0 joshuacolvin0 deleted the create-new-deployment-for-reporting branch April 8, 2026 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants