Makify SP1. Record a few types of blocks.#4667
Merged
pmikolajczyk41 merged 18 commits intozk-prove-any/sp1-runnerfrom Apr 24, 2026
Merged
Makify SP1. Record a few types of blocks.#4667pmikolajczyk41 merged 18 commits intozk-prove-any/sp1-runnerfrom
pmikolajczyk41 merged 18 commits intozk-prove-any/sp1-runnerfrom
Conversation
…. Reduce testcases, do some refactors
Contributor
❌ 9 Tests Failed:
View the top 3 failed tests by shortest run time
📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## zk-prove-any/sp1-runner #4667 +/- ##
===========================================================
- Coverage 34.90% 33.24% -1.67%
===========================================================
Files 501 501
Lines 60225 60225
===========================================================
- Hits 21022 20022 -1000
- Misses 35382 36625 +1243
+ Partials 3821 3578 -243 |
e5a9661
into
zk-prove-any/sp1-runner
35 of 36 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of NIT-4820
Split
build.shinto multiplemaketargets. Some of them (likerecord-blocks) will be useful for profiling.The system 'test' that records different blocks was heavily based on Igor's #4474. It was put under
block_recordingcompilation tag, so that these are not run during standard CI.