Skip to content

Makify SP1. Record a few types of blocks.#4667

Merged
pmikolajczyk41 merged 18 commits intozk-prove-any/sp1-runnerfrom
pmikolajczyk/nit-4820-profiling
Apr 24, 2026
Merged

Makify SP1. Record a few types of blocks.#4667
pmikolajczyk41 merged 18 commits intozk-prove-any/sp1-runnerfrom
pmikolajczyk/nit-4820-profiling

Conversation

@pmikolajczyk41
Copy link
Copy Markdown
Member

part of NIT-4820

Split build.sh into multiple make targets. Some of them (like record-blocks) will be useful for profiling.
The system 'test' that records different blocks was heavily based on Igor's #4474. It was put under block_recording compilation tag, so that these are not run during standard CI.

@pmikolajczyk41 pmikolajczyk41 changed the title makify SP1 Makify SP1 Apr 23, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 23, 2026

❌ 9 Tests Failed:

Tests completed Failed Passed Skipped
5014 9 5005 0
View the top 3 failed tests by shortest run time
TestChallengeToErroredOSP
Stack Traces | 0.040s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
    challenge_test.go:38: goroutine 748 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.9/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x2dec7b0, 0xc000d521c0}, {0x2dc8a00, 0xc0012a0f60}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x9f
        github.com/offchainlabs/nitro/staker/legacy.Require(0xc000d521c0, {0x2dc8a00, 0xc0012a0f60}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/staker/legacy/common_test.go:14 +0x5d
        github.com/offchainlabs/nitro/staker/legacy.DeployOneStepProofEntry(0xc000d521c0, 0xc000f603f0, {0x2de03d0, 0xc00078fd88})
        	/home/runner/work/nitro/nitro/staker/legacy/challenge_test.go:38 +0x18d
        github.com/offchainlabs/nitro/staker/legacy.runChallengeTest(0xc000d521c0, 0xc0010fe740, {0x2de30d0, 0xc0019a61c8}, 0x0, 0x0, 0x0)
        	/home/runner/work/nitro/nitro/staker/legacy/challenge_test.go:135 +0x425
        github.com/offchainlabs/nitro/staker/legacy.TestChallengeToErroredOSP(0xc000d521c0)
        	/home/runner/work/nitro/nitro/staker/legacy/challenge_test.go:275 +0x99
        testing.tRunner(0xc000d521c0, 0x2be4f88)
        	/opt/hostedtoolcache/go/1.25.9/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.9/x64/src/testing/testing.go:1997 +0x465
        
    challenge_test.go:38: �[31;1m [] replacement transaction underpriced �[0;0m
--- FAIL: TestChallengeToErroredOSP (0.04s)
TestMeaninglessBatchReorg
Stack Traces | 6.600s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
INFO [04-23|16:59:18.450] 
INFO [04-23|16:59:18.450] Loaded most recent local block           number=0   hash=8e4045..936bd5 age=57y1mo2w
INFO [04-23|16:59:18.450] Initialized transaction indexer          range="last 2350000 blocks"
INFO [04-23|16:59:18.455] Submitted contract creation              hash=0x76e13556dc88584749ef179f1b2b72f5344fc5e85f81f9f90f1632eed2ac48d8 from=0x57Ff0F473737a1c161bfF9efDF016F7991585088 nonce=16  contract=0xffd0c2C95214aa9980D7419bd87c260C80Ce2546 value=0
INFO [04-23|16:59:18.455] Deploying ospEntry
INFO [04-23|16:59:18.455] Starting work on payload                 id=0x03f60be28baf281e
INFO [04-23|16:59:18.456] Updated payload                          id=0x03b74b82980b43a8 number=29  hash=7a1449..57d2c8 txs=1  withdrawals=0 gas=87342      fees=8.7342e-08     root=903b0f..c13d88 elapsed=13.112ms
INFO [04-23|16:59:18.456] Stopping work on payload                 id=0x03b74b82980b43a8 reason=delivery
WARN [04-23|16:59:18.458] Served eth_getTransactionReceipt         reqid=3    duration="28.373µs"   err="transaction indexing is in progress" errdata="\"transaction indexing is in progress\""
INFO [04-23|16:59:18.458] Log index head rendering in progress     firstblock=0 lastblock=1 processed=2 remaining=0 elapsed=1.125s
INFO [04-23|16:59:18.458] Log index head rendering finished        firstblock=0 lastblock=1 processed=2 elapsed=1.125s
INFO [04-23|16:59:18.459] Ethereum protocol stopped
INFO [04-23|16:59:18.459] Transaction pool stopped
INFO [04-23|16:59:18.459] Persisting dirty state                   head=32  root=1232a7..263134 layers=32
INFO [04-23|16:59:18.460] Updated payload                          id=0x03f60be28baf281e number=19  hash=452b44..4399bc txs=1  withdrawals=0 gas=4,235,498  fees=4.235498e-06   root=1afdb8..1a08a3 elapsed=4.343ms
INFO [04-23|16:59:18.460] Stopping work on payload                 id=0x03f60be28baf281e reason=delivery
INFO [04-23|16:59:18.461] Persisted dirty state to disk            size=146.18KiB elapsed=1.867ms
INFO [04-23|16:59:18.461] Blockchain stopped
--- FAIL: TestMeaninglessBatchReorg (6.60s)
INFO [04-23|16:59:18.659] InboxTracker                             sequencerBatchCount=3 messageCount=10 l1Block=69 l1Timestamp=2026-04-23T16:59:43+0000
TestAnyTrustRekey
Stack Traces | 8.770s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
        	/opt/hostedtoolcache/go/1.25.9/x64/src/testing/testing.go:1997 +0x465
        
    common_test.go:1009: �[31;1m [failed to deploy ArbDebug] wrong msgIdx got 1 expected 2 �[0;0m
INFO [04-23|16:59:19.364] New Key                                  name=Faucet              Address=0xaF24Ca6c2831f4d4F629418b50C227DF0885613A
INFO [04-23|16:59:19.364] New Key                                  name=RollupOwner         Address=0x57Ff0F473737a1c161bfF9efDF016F7991585088
ERROR[04-23|16:59:19.364] Error in message extractor               err="context canceled"
INFO [04-23|16:59:19.364] New Key                                  name=Sequencer           Address=0xb386a74Dcab67b66F8AC07B4f08365d37495Dd23
INFO [04-23|16:59:19.364] New Key                                  name=Validator           Address=0x83FFCFaCE2Fb0E1286686815503608A16EF41e47
ERROR[04-23|16:59:19.364] SequencerInbox GetBatchCount error, using headState.BatchCount fallback err="context canceled"                    parentChainBlock=31
INFO [04-23|16:59:19.364] New Key                                  name=User                Address=0x7E23C8862920797d81916d62c274dd9217113e28
INFO [04-23|16:59:19.364] Updated payload                          id=0x03e4a760c1fcfa28 number=76  hash=569613..7b32ac txs=1  withdrawals=0 gas=21000      fees=0.002099853107 root=18933d..5def68 elapsed=1.366ms
INFO [04-23|16:59:19.365] Allocated trie memory caches             clean=154.00MiB dirty=256.00MiB
INFO [04-23|16:59:19.365] State schema set to default              scheme=path
INFO [04-23|16:59:19.365] Stopping work on payload                 id=0x03e4a760c1fcfa28 reason=delivery
INFO [04-23|16:59:19.364] New Key                                  name=Faucet              Address=0xaF24Ca6c2831f4d4F629418b50C227DF0885613A
WARN [04-23|16:59:19.365] Head block is not reachable
INFO [04-23|16:59:19.365] Starting work on payload                 id=0x03dde15bfb85cc3f
INFO [04-23|16:59:19.365] New Key                                  name=RollupOwner         Address=0x57Ff0F473737a1c161bfF9efDF016F7991585088
INFO [04-23|16:59:19.365] New Key                                  name=Sequencer           Address=0xb386a74Dcab67b66F8AC07B4f08365d37495Dd23
--- FAIL: TestAnyTrustRekey (8.77s)

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 33.24%. Comparing base (a8a984e) to head (ced64e8).
⚠️ Report is 19 commits behind head on zk-prove-any/sp1-runner.

Additional details and impacted files
@@                     Coverage Diff                     @@
##           zk-prove-any/sp1-runner    #4667      +/-   ##
===========================================================
- Coverage                    34.90%   33.24%   -1.67%     
===========================================================
  Files                          501      501              
  Lines                        60225    60225              
===========================================================
- Hits                         21022    20022    -1000     
- Misses                       35382    36625    +1243     
+ Partials                      3821     3578     -243     

@pmikolajczyk41 pmikolajczyk41 changed the title Makify SP1 Makify SP1. Record a few types of blocks. Apr 23, 2026
Copy link
Copy Markdown
Contributor

@bragaigor bragaigor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pmikolajczyk41 pmikolajczyk41 merged commit e5a9661 into zk-prove-any/sp1-runner Apr 24, 2026
35 of 36 checks passed
@pmikolajczyk41 pmikolajczyk41 deleted the pmikolajczyk/nit-4820-profiling branch April 24, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants