Skip to content
This repository was archived by the owner on Jun 18, 2024. It is now read-only.

Minor bug fixes#342

Merged
serious6 merged 4 commits intoOfficeDev:masterfrom
vbauer:minor-bugs
Jun 5, 2015
Merged

Minor bug fixes#342
serious6 merged 4 commits intoOfficeDev:masterfrom
vbauer:minor-bugs

Conversation

@vbauer
Copy link
Copy Markdown
Contributor

@vbauer vbauer commented Jun 3, 2015

No description provided.

vbauer added 3 commits June 4, 2015 03:10
@vbauer
Remove unnecessary assertions
9fd25c2
@vbauer
Simplify constant expressions
9f011d1
@vbauer
Fix possible bugs:
7934a43 
- Fix incorrect "compare" method in the TimeZoneDefinition class
- Fix NPE in the AttachmentCollection class
- Fix incorrect casting in the ComplexPropertyDefinitionBase class
@azurecla
Copy link
Copy Markdown

azurecla commented Jun 3, 2015

Hi @vbauer, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.

TTYL, AZPRBOT;

@serious6
Copy link
Copy Markdown
Member

serious6 commented Jun 5, 2015

👍

serious6
serious6 reviewed Jun 5, 2015
View reviewed changes
Comment thread src/main/java/microsoft/exchange/webservices/data/search/filter/SearchFilter.java
Copy link
Copy Markdown
Member

@serious6 serious6 Jun 5, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you have some words on why you removed that block?

Copy link
Copy Markdown
Contributor Author

@vbauer vbauer Jun 5, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The next line was:

if (!((value instanceof Object) || (value instanceof ISearchStringProvider)))

Any not-null object is instance of Object class, so this expressions is always "true", it means that full expressions is always "false".

Copy link
Copy Markdown
Member

@serious6 serious6 Jun 5, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so the ISearchStringProvider check was a bug?

Copy link
Copy Markdown
Contributor Author

@vbauer vbauer Jun 5, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep... the first part of this expression is always "true".

@vbauer
Copy link
Copy Markdown
Contributor Author

vbauer commented Jun 5, 2015

JFYI: I've just removed unnecessary "instanceof" operator in the last commit.

serious6 added a commit that referenced this pull request Jun 5, 2015
@serious6
Merge pull request #342 from vbauer/minor-bugs
75904e2 
Remove unnecessary assertions, Simplify constant expressions. minor bug fixes
@serious6 serious6 merged commit 75904e2 into OfficeDev:master Jun 5, 2015
@serious6
Copy link
Copy Markdown
Member

serious6 commented Jun 5, 2015

@vbauer thanks for your contribution

@serious6 serious6 added this to the 2.0 milestone Jul 9, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@vbauer @azurecla @serious6