Skip to content
This repository was archived by the owner on Jun 18, 2024. It is now read-only.

Issue #425: Fix parsing AlternateMailboxCollection#431

Merged
serious6 merged 1 commit intoOfficeDev:masterfrom
thomaswoeckinger:master
Nov 24, 2015
Merged

Issue #425: Fix parsing AlternateMailboxCollection#431
serious6 merged 1 commit intoOfficeDev:masterfrom
thomaswoeckinger:master

Conversation

@thomaswoeckinger
Copy link
Copy Markdown

Fixed typo

@azurecla
Copy link
Copy Markdown

Hi @thomaswoeckinger, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;

@vboctor
Copy link
Copy Markdown
Contributor

vboctor commented Sep 1, 2015

Thanks @thomaswoeckinger for your contribution. Please update the pull request to only include the functional fix without the unrelated formatting fixes. Please also include test cases.

@thomaswoeckinger
Copy link
Copy Markdown
Author

It is formated with Google code format as described on the contribution page
Am 01.09.2015 05:40 schrieb "Victor Boctor" notifications@github.com:

Thanks @thomaswoeckinger https://github.com/thomaswoeckinger for your
contribution. Please update the pull request to only include the functional
fix without the unrelated formatting fixes. Please also include test cases.


Reply to this email directly or view it on GitHub
#431 (comment)
.

@serious6 serious6 modified the milestone: 2.0 Sep 2, 2015
@serious6
Copy link
Copy Markdown
Member

@thomaswoeckinger maybe you can just revert the changes in the license-header? The other ones may be no problem.

@thomaswoeckinger thomaswoeckinger force-pushed the master branch 2 times, most recently from 890d94e to c9530ef Compare October 21, 2015 18:09
@thomaswoeckinger
Copy link
Copy Markdown
Author

License header reverted/added

@serious6
Copy link
Copy Markdown
Member

@thomaswoeckinger thanks for your contribution. Think we can get this in shortly.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add return tag value

@vboctor
Copy link
Copy Markdown
Contributor

vboctor commented Oct 27, 2015

@thomaswoeckinger the PR looks good. I added a couple of minor comments.

@serious6
Copy link
Copy Markdown
Member

serious6 commented Nov 8, 2015

@thomaswoeckinger maybe we can have this merged once you fixed the documentation issues. Maybe also squash your commits.

@serious6 serious6 added this to the 2.1 milestone Nov 8, 2015
@thomaswoeckinger
Copy link
Copy Markdown
Author

Once again; I can add documentation on the properties or the class.

The difference is that the OwnerSmtpAddress is the SMTP address of owner of the alternate mailbox, and the SmtpAddress belongs to the mailbox itself.

The SmtpAddress is only set if it is available for the given Type e.g. Delegate has an SmtpAddress set Archive not.

@codecov-io
Copy link
Copy Markdown

Current coverage is 10.43%

Merging #431 into master will increase coverage by +0.35% as of 0c45ae5

@@            master    #431   diff @@
======================================
  Files          550     550       
  Stmts        20419   20429    +10
  Branches      2620    2625     +5
  Methods          0       0       
======================================
+ Hit           2060    2131    +71
- Partial        148     153     +5
+ Missed       18211   18145    -66

Review entire Coverage Diff as of 0c45ae5

Powered by Codecov. Updated on successful CI builds.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz dont format license header

@serious6
Copy link
Copy Markdown
Member

please Squash your commits.

@thomaswoeckinger
Copy link
Copy Markdown
Author

Documented and squashed

@serious6
Copy link
Copy Markdown
Member

PR still contains several commits.

@thomaswoeckinger
Copy link
Copy Markdown
Author

Squashed to a single commit

serious6 pushed a commit that referenced this pull request Nov 24, 2015
Issue #425: Fix parsing AlternateMailboxCollection
@serious6 serious6 merged commit 764f0dd into OfficeDev:master Nov 24, 2015
@serious6
Copy link
Copy Markdown
Member

@thomaswoeckinger Thanks for your contribution

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants