Issue #425: Fix parsing AlternateMailboxCollection#431
Issue #425: Fix parsing AlternateMailboxCollection#431serious6 merged 1 commit intoOfficeDev:masterfrom
Conversation
|
Hi @thomaswoeckinger, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution! TTYL, AZPRBOT; |
|
Thanks @thomaswoeckinger for your contribution. Please update the pull request to only include the functional fix without the unrelated formatting fixes. Please also include test cases. |
|
It is formated with Google code format as described on the contribution page
|
|
@thomaswoeckinger maybe you can just revert the changes in the license-header? The other ones may be no problem. |
890d94e to
c9530ef
Compare
|
License header reverted/added |
|
@thomaswoeckinger thanks for your contribution. Think we can get this in shortly. |
|
@thomaswoeckinger the PR looks good. I added a couple of minor comments. |
|
@thomaswoeckinger maybe we can have this merged once you fixed the documentation issues. Maybe also squash your commits. |
|
Once again; I can add documentation on the properties or the class. The difference is that the OwnerSmtpAddress is the SMTP address of owner of the alternate mailbox, and the SmtpAddress belongs to the mailbox itself. The SmtpAddress is only set if it is available for the given Type e.g. Delegate has an SmtpAddress set Archive not. |
Current coverage is
|
There was a problem hiding this comment.
plz dont format license header
|
please Squash your commits. |
|
Documented and squashed |
|
PR still contains several commits. |
8f7b32e to
54a06c4
Compare
|
Squashed to a single commit |
Issue #425: Fix parsing AlternateMailboxCollection
|
@thomaswoeckinger Thanks for your contribution |
Fixed typo