Merged
Conversation
added 2 commits
October 9, 2019 23:14
Modified `decoder.py` - added a check for the type of the payload provided. sometimes seen it to be a byte string. will raise TypeError - handler when the sensor type wasn't found or nor defined at all. Library will return intermediate result and print the error - added handler for cases when the payload length is incorrect. This will raise the ValueError - added a broad except to raise any uncaugh exceptions, but print out what was already decoded for future debugging.
Owner
Author
|
This is a fix for #1 issue. I want to also add unit tests before merging. |
added 7 commits
October 11, 2019 23:50
requirements.txt have only tools for testing
also default strings handling is different. in 2.7 the string literal is str and stored as bytes in 3.7 it's str stored as unicode.
also edited setup to be ready to push the change
Codecov Report
@@ Coverage Diff @@
## master #2 +/- ##
=======================================
Coverage ? 100%
=======================================
Files ? 5
Lines ? 149
Branches ? 0
=======================================
Hits ? 149
Misses ? 0
Partials ? 0
Continue to review full report at Codecov.
|
Owner
Author
|
Fixed #1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved error handling at the decoder
Modified
decoder.py