Skip to content

CI: isort GitHub action doesn't report expected issues #115

@elliot-100

Description

@elliot-100

PR #107 passed all CI checks including isort linting: https://github.com/Olen/Spond/actions/runs/9096951441

Expected behaviour: flag unsorted imports, fail all builds and thus all required checks.

If I run isort on it locally, I get a number of issues:

(spond-LnXcNOlD-py3.8) ~\code\elliot-100_Spond git:[feat/club]
isort . --check-only
ERROR: C:\Users\bb\code\elliot-100_Spond\manual_test_functions.py Imports are incorrectly sorted and/or formatted.
ERROR: C:\Users\bb\code\elliot-100_Spond\transactions.py Imports are incorrectly sorted and/or formatted.
ERROR: C:\Users\bb\code\elliot-100_Spond\spond\club.py Imports are incorrectly sorted and/or formatted.
ERROR: C:\Users\bb\code\elliot-100_Spond\spond\spond.py Imports are incorrectly sorted and/or formatted.
ERROR: C:\Users\bb\code\elliot-100_Spond\tests\test_spond.py Imports are incorrectly sorted and/or formatted.
Skipped 2 files

Should investigate and verify other checks are working OK.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions