Skip to content

Small improvements and refactors#110

Merged
elliot-100 merged 3 commits intoOlen:mainfrom
elliot-100:misc-improvements2
May 23, 2024
Merged

Small improvements and refactors#110
elliot-100 merged 3 commits intoOlen:mainfrom
elliot-100:misc-improvements2

Conversation

@elliot-100
Copy link
Collaborator

No description provided.

@elliot-100 elliot-100 marked this pull request as draft May 20, 2024 16:37
@elliot-100 elliot-100 self-assigned this May 20, 2024
@Olen
Copy link
Owner

Olen commented May 23, 2024

This should be meged before #107 and #107 must probably be rebased after merge.

@elliot-100 elliot-100 force-pushed the misc-improvements2 branch from b66906a to 187bbc9 Compare May 23, 2024 15:58
@elliot-100
Copy link
Collaborator Author

Rebased, better commit messages, and dropped the change to type hints which probably belongs in a separate type hints enhancement as there may be a few oddities.

@elliot-100 elliot-100 marked this pull request as ready for review May 23, 2024 16:04
@Olen
Copy link
Owner

Olen commented May 23, 2024

Looks fine. Have not tested it, but no obvious typos at least...

@elliot-100 elliot-100 merged commit 6b4a9fc into Olen:main May 23, 2024
@elliot-100 elliot-100 deleted the misc-improvements2 branch May 23, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants