Nicer cleanup of player skill animations

[LiquidityC]

Summary by CodeRabbit

• Refactor
  • Streamlined resource cleanup in the player logic to improve memory management, reduce indirection, and enhance maintainability. No changes to gameplay, UI, or behavior.
• Chores
  • Internal code hygiene improvements with no impact on public APIs or integrations.
  • Reinforced consistency in cleanup routines to support long-term stability.
  • No user-facing changes; existing features continue to work as before.

[coderabbitai]

Walkthrough

The change removes a static helper that freed skill animations and replaces its usage with an inline loop inside player_destroy to pop and free list nodes from player->skillAnimations. No public interfaces are altered.

Changes

Cohort / File(s)	Summary
Skill animations cleanup refactor src/player.c	Removed static destroy_skill_animations(LinkedList *skillAnimations); in player_destroy, replaced helper call with a loop popping from player->skillAnimations until NULL to free nodes. No exported signatures changed.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• Adds 3 new animations sprite sheets replaces sword swing. #133 — Introduced update/render/destroy for skill animations and player->skillAnimations handling; directly related to this PR’s removal of the destroy helper in favor of inline cleanup.

Poem

In code-burrows deep, I hop with delight,
Snipping a helper, keeping cleanup light.
Pop, pop, the list goes—quietly freed,
A lean little loop does all that we need.
Nose-twitch of joy: fewer trails to sweep,
Bugs sleep sound as pointers keep. 🐇✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title succinctly describes the main change of improving cleanup logic for player skill animations and aligns with the actual code modifications, making it clear to reviewers what was altered.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch minor_player_mem_fix

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2598f1e and b9096e3.

📒 Files selected for processing (1)

• src/player.c (1 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

src/player.c (1)

src/linkedlist.c (1)

• linkedlist_pop (48-59)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)

• GitHub Check: Mac (GCC)
• GitHub Check: Mac (Clang)
• GitHub Check: Windows (MSVC)
• GitHub Check: Ubuntu (GCC)
• GitHub Check: Ubuntu (Clang)
• GitHub Check: Ubuntu (mingw)
• GitHub Check: Analyze (c-cpp)

🔇 Additional comments (1)

src/player.c (1)

878-880: LGTM! Clean simplification of the cleanup logic.

The inline loop correctly frees the list node structure. Since animations are owned by skills (destroyed at lines 872-876), the returned data pointers from linkedlist_pop can safely be discarded. The approach is straightforward and eliminates the need for a dedicated helper function.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}