Collapse redundant run-arg id lists in benchmark_runner cli#9
Open
alamb wants to merge 1 commit into
Open
Conversation
`RUN_ENV_ARG_IDS` listed every `CommonOpt` arg in order to hide their env-variable annotations from `run` help. Every `CommonOpt` field carries an `env` and none of the hand-added run args do, so hiding env on every argument via `Command::mut_args` is equivalent and removes the list that nearly (but not exactly) duplicated `DATAFUSION_ARG_IDS`. Also removes the now-unused `hide_env_annotations` helper and documents that `DATAFUSION_ARG_IDS` is every `CommonOpt` arg except `iterations`. Rendered `run` help output is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
benchmark_runnerinfo and query commands apache/datafusion#22032Rationale for this change
While simplifying
benchmarks/src/benchmark_runner/cli.rsI noticedRUN_ENV_ARG_IDSandDATAFUSION_ARG_IDSwere almost-identical lists, differing only byiterations. EveryCommonOptarg has anenv, so hiding env annotations on all args lets me drop the duplicate list (and its helper) entirely.Here is a proposal for your consideration