Refactor CommandKnowledgeBase into a plugin architecture#1
Merged
Conversation
Replace the monolithic knowledge table + switch with composable CommandKnowledgePlugins (one per domain) producing declarative CommandKnowledge entries. Entries carry richer metadata (category, platforms, description) plus a SecurityLevel risk hint, sub-command and argument rules (ExactFlag/PrefixFlag/TokenPresent/ArgRegex/ArgPredicate), per-entry WrapperSpec and an optional refine hook. - analyze() returns a CommandKnowledgeResult (capabilities, risk, matched entry, notes); capabilitiesFor() kept as a convenience seam. - Opt-in KnowledgeRiskDetector + CommandAnalysis.knowledgeRisk surface risk without changing default security verdicts. - Sub-command matching uses the first non-flag argument. - Broader coverage: dart/flutter, archives, cloud CLIs, more git, etc. BREAKING: removes extraExecutableCapabilities ctor param and the static wrapperCommands set; use plugins and WrapperSpec instead. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the monolithic knowledge table + switch with composable CommandKnowledgePlugins (one per domain) producing declarative CommandKnowledge entries. Entries carry richer metadata (category, platforms, description) plus a SecurityLevel risk hint, sub-command and argument rules (ExactFlag/PrefixFlag/TokenPresent/ArgRegex/ArgPredicate), per-entry WrapperSpec and an optional refine hook.
BREAKING: removes extraExecutableCapabilities ctor param and the static wrapperCommands set; use plugins and WrapperSpec instead.