Nathalia new filter project by user name#1006
Conversation
…tered both first name and last name
…GNRest into Nathalia-new-filter-project-by-user-name
HowieMiao
left a comment
There was a problem hiding this comment.
Tested PR with first name, last name, both, as well as non existent users to ensure no results found pop-up. Tested to make sure capitalization is not an issue either, no issues.
pr-1006.BE.2392.FE.mp4
pavanswaroopl
left a comment
There was a problem hiding this comment.
There's a minor issue, not sure whether it's an obvious behavior, but can you please have a look at the scenario below:
I am searching with my name which is "Pavan Swaroop Lebakula",
when I search for Pavan, it shows a project, which is good, and shows a successful fetch,
but when I search with "pavan s", it throws the error that nothing is found.
Logeshwari-Renu
left a comment
There was a problem hiding this comment.
I have tested the PR and the functionality works fine. Left review on frontend
DiyaWadhwani
left a comment
There was a problem hiding this comment.
Hi Nathalia,
I have tested your changes and dropped a comment on your frontend PR.
OneCommunityGlobal/HighestGoodNetworkApp#2392 (review)
Thank you.
jinxyou
left a comment
There was a problem hiding this comment.
I left a review at frontend, which can be found here: OneCommunityGlobal/HighestGoodNetworkApp#2392 (review)
|
your changes work great and i left the review on frontend PR |
vijay10pk
left a comment
There was a problem hiding this comment.
Changes works as expected for the all the scenarios. Refer to Front-end PR Comment Link
|
Hi, |
…GNRest into Nathalia-new-filter-project-by-user-name
nikhilpittala16
left a comment
There was a problem hiding this comment.
I left a review on the frontend PR, it can be found here: [https://github.com/OneCommunityGlobal/HighestGoodNetworkApp/pull/2392#pullrequestreview-2159480777]

Description
Related PRS (if any):
This backend PR is related to the #2392 frontend PR.
Main changes explained:
How to test:
npm install,npm run buildandnpm run startto run this PR locallyScreenshots or videos of changes:
Video.1.mp4
Note:
It's really important to run
npm run build