Skip to content

Nathalia new filter project by user name#1006

Merged
one-community merged 8 commits into
developmentfrom
Nathalia-new-filter-project-by-user-name
Jul 6, 2024
Merged

Nathalia new filter project by user name#1006
one-community merged 8 commits into
developmentfrom
Nathalia-new-filter-project-by-user-name

Conversation

@nathcarnevalli
Copy link
Copy Markdown
Contributor

Description

image

Related PRS (if any):

This backend PR is related to the #2392 frontend PR.

Main changes explained:

  • Created the getProjectByPerson function in userProfileController.js
  • Created the route to call the getProjectByPerson function

How to test:

  1. Check into current branch
  2. Run npm install, npm run build and npm run start to run this PR locally
  3. Go to the #2392 frontend PR and follow the steps

Screenshots or videos of changes:

Video.1.mp4

Note:

It's really important to run npm run build

@nathcarnevalli nathcarnevalli added the Do Not Review Do not review or look at code without full context label Jun 28, 2024
@nathcarnevalli nathcarnevalli added High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible and removed Do Not Review Do not review or look at code without full context labels Jun 28, 2024
Copy link
Copy Markdown

@HowieMiao HowieMiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested PR with first name, last name, both, as well as non existent users to ensure no results found pop-up. Tested to make sure capitalization is not an issue either, no issues.

pr-1006.BE.2392.FE.mp4

Copy link
Copy Markdown
Contributor

@pavanswaroopl pavanswaroopl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a minor issue, not sure whether it's an obvious behavior, but can you please have a look at the scenario below:

I am searching with my name which is "Pavan Swaroop Lebakula",
when I search for Pavan, it shows a project, which is good, and shows a successful fetch,
but when I search with "pavan s", it throws the error that nothing is found.

Screenshot 2024-06-28 at 2 35 53 PM Screenshot 2024-06-28 at 2 36 45 PM Screenshot 2024-06-28 at 2 36 36 PM

@Logeshwari-Renu Logeshwari-Renu self-requested a review June 28, 2024 23:05
Copy link
Copy Markdown
Contributor

@Logeshwari-Renu Logeshwari-Renu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the PR and the functionality works fine. Left review on frontend

Copy link
Copy Markdown

@sahithidhulipala9 sahithidhulipala9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the names already listed, search results are displaying the corresponding projects. But for the person names that aren't listed in projects, i am not getting the error message.
PR 1006+ 2392

Copy link
Copy Markdown
Contributor

@DiyaWadhwani DiyaWadhwani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Nathalia,

I have tested your changes and dropped a comment on your frontend PR.
OneCommunityGlobal/HighestGoodNetworkApp#2392 (review)

Thank you.

Copy link
Copy Markdown

@jinxyou jinxyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a review at frontend, which can be found here: OneCommunityGlobal/HighestGoodNetworkApp#2392 (review)

@vishavk1992
Copy link
Copy Markdown

your changes work great and i left the review on frontend PR
OneCommunityGlobal/HighestGoodNetworkApp#2392 (review)

Copy link
Copy Markdown
Contributor

@vijay10pk vijay10pk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes works as expected for the all the scenarios. Refer to Front-end PR Comment Link

@KaushikMreddy
Copy link
Copy Markdown

Hi,
I've reviewed this PR in the frontend.

Copy link
Copy Markdown
Contributor

@nikhilpittala16 nikhilpittala16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a review on the frontend PR, it can be found here: [https://github.com/OneCommunityGlobal/HighestGoodNetworkApp/pull/2392#pullrequestreview-2159480777]

@nathcarnevalli nathcarnevalli requested a review from vijay10pk July 4, 2024 22:07
Copy link
Copy Markdown

@HowieMiao HowieMiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible

Projects

None yet

Development

Successfully merging this pull request may close these issues.