Carlos new pie chart hour visualization by team member project reports#1015
Merged
one-community merged 12 commits intoJul 6, 2024
Conversation
…_by_Team_Member__Project_Reports
one-community
added
the
High Priority - Please Review First
HowieMiao
approved these changes
Jul 3, 2024
Parth-tech
approved these changes
Jul 3, 2024
Contributor
Parth-tech
left a comment
Parth-tech
left a comment
There was a problem hiding this comment.
Hey Carlos,
Nice job on the backend.
I have request a few changes on the frontend repo: front-end review
DiyaWadhwani
approved these changes
Jul 5, 2024
Contributor
There was a problem hiding this comment.
Hi Carlos,
Everything works as expected. I have a left a comment and video implementation on your frontend PR.
OneCommunityGlobal/HighestGoodNetworkApp#2409 (review)
Thank you
vishavk1992
reviewed
Jul 5, 2024
vishavk1992
left a comment
vishavk1992
left a comment
There was a problem hiding this comment.
it works as intended and i also left comment on frontend PR2409
cgomezhub
added
Do Not Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Backend PR is related to supporting proposal changes in Frontend PR2409
Description
The graph currently displays weekly committed hours by project member. However, it does not show the actual hours worked by member on each project.
(PRIORITY HIGH) Jae: Add “Hours by Team Member” Visualization to the Projects Reports page (WIP Carlos)
Main changes explained:
in getTimeEntriesForSpecifiedProjectadd, add firstName lastName and isActive properties in 'TimeEntry' Schema from 'userProfile' Schema with will be received in the fronted.
How to test:
check into current branch
do npm install and ... to run this PR locally
Clear site data/cache
log as Owner, manager or admin user
Folllow Frontend intructions
Requested job:
task
video before the change:
https://www.loom.com/share/7be14c4aec464c5fbb9669a11c4d63b5?sid=586d7ba2-8f94-4a4a-99e6-6725b31d4236
video after the change:
https://www.loom.com/share/889ae08438b94daca7d4f63f9905cb07?sid=2039627e-1faa-43ae-84a6-6d5f3b8a53af
Note:
You must add a project for at least one user ( set as a poject member)
You must log hours for this member(s) in this project.
Go to dashboard => report => type the project => PieChart => pick the charts
4.See videos above for more info