Aryan Quality Distribution Charts Backend#1899
Merged
one-community merged 2 commits intodevelopmentfrom Nov 20, 2025
Merged
Conversation
Aditya-gam
approved these changes
Nov 20, 2025
Contributor
Aditya-gam
left a comment
There was a problem hiding this comment.
- I followed the provided test plan (fresh install, cache cleared, logged in as owner) to verify this PR.
- The PR successfully adds team member count functionality to the PR Quality Distribution endpoint.
- All test cases pass (verified in test video), including basic requests returning
memberCountcorrectly and edge cases (invalid duration, empty/missing params, non-existent teams) being handled appropriately. - The implementation correctly passes
userProfilethrough the controller and router layers.
TestVideo.mov
Minor non-breaking Issues:
- Date mutation bug:
now.setDate()andnow.setMonth()mutate the Date object. While the current if-else structure prevents issues, this is fragile and could cause problems if the code is refactored. - Missing null/undefined handling: If
team._idis null or undefined,countDocumentsmay behave unexpectedly. - Error handling in Promise.all: If any single
countDocumentscall fails, the entirePromise.allwill reject, causing the whole request to fail.
Member
|
Thank you all, merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related PRs (if any)
Main changes explained
How to test
Check out the current branch.
Run:
npm installnpm run buildnpm startStart the frontend to load the updated UI.
Clear site data / cache.
Log in as an admin user.
Navigate to:
localhost:5173/pull-request-analytics/reviews-insight
Set:
Observe the PR Quality Distribution section.
Screenshots of changes