Skip to content

Navneeth create see project management tab custom permission#545

Merged
one-community merged 2 commits intodevelopmentfrom
navneeth-create-see-project-management-tab-custom-permission
Oct 1, 2023
Merged

Navneeth create see project management tab custom permission#545
one-community merged 2 commits intodevelopmentfrom
navneeth-create-see-project-management-tab-custom-permission

Conversation

@navneeeth
Copy link
Copy Markdown
Contributor

@navneeeth navneeeth commented Sep 23, 2023

Description

bug description

Related PRs:

This PR is linked to the FE PR #1336.

Main changes explained:

  • Updated the permission checks for not allowing creating/updating/deleting of projects if the user also does not have individual permission 'seeProjectManagement'.
  • Updated the permission checks for not allowing listing users (used while adding members) and assigning projects to users if the user also does not have either 'seeProjectManagement' or 'seeProjectManagementTab' permissions.

How to test:

  1. check into current branch
  2. do npm install and npm run build and npm run start successively to run this PR locally

Copy link
Copy Markdown
Contributor

@Shiwani99 Shiwani99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
Great work. Left comments at frontend PR#1336.

Copy link
Copy Markdown

@JYXiao-2021 JYXiao-2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, left comment at FE. Great job

@Lin1404 Lin1404 self-requested a review September 30, 2023 21:57
@EdwinLauM EdwinLauM self-requested a review October 1, 2023 01:16
Copy link
Copy Markdown
Contributor

@EdwinLauM EdwinLauM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @navneeeth! Left a more detailed review in your FE PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants