Skip to content

Bailey add link to submit review#1806

Merged
one-community merged 2 commits intodevelopmentfrom
Bailey-add-link-to-submit-review
Jan 24, 2024
Merged

Bailey add link to submit review#1806
one-community merged 2 commits intodevelopmentfrom
Bailey-add-link-to-submit-review

Conversation

@BaileyM96
Copy link
Copy Markdown
Contributor

Description

Screenshot 2024-01-10 at 2 53 54 PM

Related PRS (if any):

This frontend PR is related to the #696 PR This is needed to test this new functionality.

Main changes explained:

  • Added new states for adding the link, and to open the new verification modals
  • Created a condition that checks existing tasks if they have the new task field relatedWorkLinks and if not it creates it upon submission
  • Created a new field in the task model in the back end named relatedWorkLinks to store the users links
  • Created an input field for users when submitting their work to be reviewed.
  • Then I created a verification modal for the owner, admin, and manager roles that verifies if you are ready to mark it as complete or mark it for re review

How to test:

  1. check into current branch
  2. do npm install and npm run start:local to run this PR locally
  3. Clear site data/cache
  4. log as either owner, admin, manager, or mentor user
  5. Either create a new task and assign your test account or use an existing task and assign yourself to it.
  6. go to dashboard→ Tasks→ task→ submit for review→ add a link to the input field→ Submit→
  7. Now logout of your test account and log as owner, admin etc. Tasks→ task→ Ready for Review→ view link→ Mark as Complete or More Work Needed, reset this button→ to verify if the new modals work

Screenshots or videos of changes:

Creating a task for a user demo

Creating.a.Task.for.User.Demo.mov

Walkthrough for testing

Adding.a.Link.to.Task.Demo.mov

Note:

You can also submit multiple links.

Copy link
Copy Markdown
Member

@ChengyanOo ChengyanOo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @BaileyM96,

I've tested the recent changes you've implemented, and I'm pleased to report that everything is working as expected. Here's a brief summary of the main changes. Attached is a screen recording of my test, showcasing the successful implementation of these features.

Screen.Recording.2024-01-11.at.14.24.46.mov

@one-community one-community merged commit 69f2309 into development Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants