Sai Sandeep taking over for Ramya unit test : Reports/PeopleTableDetails

[scoopstroop92]

Description

Unit test for src/components/Reports/PeopleTableDetails

Main changes explained:

• New file
  • PeopleTableDetails.test.js : unit test cases
• Existing file file
  • PeopleTableDetails.test.js : Added test id

Test cases

How to test:

1. check into current branch
2. do npm test PeopleTableDetails.test.js
3. check if all the test cases pass

Screenshots or videos of changes:

Note :

Kindly take a look at the test cases and suggest if more validations can be added

[aaryaneil]

Reviewed your PR and all the test cases passed but there were a lot of warnings generated, please look into it. Good work.

[scoopstroop92]

Reviewed your PR and all the test cases passed but there were a lot of warnings generated, please look into it. Good work.

The warning stems from the component's code design so that is not something I can address in the unit test

[Tiantian-C]

All the tests have passed.

[metaphor987]

Hi Ramya, all tests have passed on my side but there are some warnings, and it would be best to check them. Here is the screenshot showing that all tests have passed:

and here are screenshots showing some of the warnings:

Thank you!

[jennZhang93]

Testcases passed but here are some console log error that showed up.

[scoopstroop92]

@metaphor987 @aaryaneil I have fixed the console warnings. Now you shouldn't see any warnings except for warning due to the main component logic

[cgomezhub]

Good Job,!,
All test has passed . Just to avoid warning you need to add in line 221:
key={value._id} : <NewModal key={value._id} header="Task info" trigger={() => renderFilteredTask(value)}>

do it and please let me know.

[KaushikMreddy]

Hi Ramya,

All test cases have passed with 1 warning, pasting that warning here

Good work!

[dkt6]

As others have already mentioned in their comments, there is a warning to add a unique ID. Thank you for your great work!

[ZhangPeizhou]

Pass all tests, nice work!

[scoopstroop92]

@ZhangPeizhou @cgomezhub @dkn6 my understanding is the warning stems from the main component logic. I am not really sure if i can make that changes as part of this PR . I beleive it should be addressed in a separate PR altogether as the component needs to functionally tested after making any changes. Let me know your thoughts

[dkt6]

@ramyaram2092
From my understanding, simply assigning a unique key to the list of items here should be enough, and I don't think this change will have any negative impact. Whether to handle this in a separate PR is up to you, so I approve this PR. Thank you for your great work!

[Sandhya1236]

I checked out the current branch, ran npm test PeopleTableDetails.test.js, and verified that all the test cases passed. All steps were followed successfully, confirming that the functionality covered by the PeopleTableDetails.test.js file is working as intended.

[Kavil-Jain-514]

All test cases have passed. However, there is a warning for a unique key. Each element in an array rendered by a map must have a unique key prop.

You can replace the line numbers 221 to 229 in the PeopleTableDetails.jsx with this code:
{filteredTasks.map(value => (
<NewModal key={value._id} header="Task info" trigger={() => renderFilteredTask(value)}>

Why This Task is important

<textarea className="rectangle" type="text" value={value.whyInfo} readOnly />

Design Intent

<textarea className="rectangle" type="text" value={value.intentInfo} readOnly />

End State

<textarea className="rectangle" type="text" value={value.endstateInfo} readOnly />

))}

Also, you can make your code better by removing extra stuff like.
Line no. 61, remove const simple = [ ] as it is never used.
Line no. 64 to 72, use return instead of an if and return true.

[JatinAgrawal94]

All the tests pass, but with a warning.
The NewModal Component doesn't have a key prop on line 221 in PeopleTableDetails.jsx. Rest everything works fine.
Good Job.

[akshit0211]

All test cases passed but with warning. I saw your previous comment so I'm approving this.

[scoopstroop92]

the warning stems from the main component logic. I am not really sure if i can make that changes as part of this PR . I beleive it should be addressed in a separate PR a

the warning stems from the main component logic . I beleive it is better to make the changes as a seperate PR. Let me know your thoughts @JatinAgrawal94 @Kavil-Jain-514

[deepthikannan]

All test cases passed.

[Vigneshwar-Muriki]

Tested this PR as mentioned in the instructions and its working as intended. All test cases have passed.

[AnujVakil]

I have tested this PR and all test cases are passed

[ZhangPeizhou]

all tests are passed, well done!

[Shadhrush5]

Hi, I have reviewed PR 2102. I followed the steps as mentioned and see that all the test cases execute and is working as expected. Thank you for the great work.

[vamshik2024]

Reviewed the PR, test cases passed but could see couple of warnings related to keys while rendering PeopleTableDetails

Good work!

[souravwalke]

I have reviewed PR 2102 and all the test cases executed without any fail.

[Gmon-k]

I have tested from my side and all the test cases has passed. It looks fine.

[navya9989]

Hi, I have tested this PR and all test suits have passed, Good worl!
@

[SatyashanthiT]

I reviewed and tested PR for the Reports/PeopleTableDetails unit tests. Verified that all test cases outlined in PeopleTableDetails.test.js passed, confirming the expected behavior for the component.

[geetamatkar]

Tested this PR and all the test cases have passed.