Tapan Fixed the Pagination UI in Members Table for Project Reports#2201
Merged
Merged
Conversation
linkhanthtel
approved these changes
Apr 27, 2024
linkhanthtel
left a comment
linkhanthtel
left a comment
There was a problem hiding this comment.
There is no pagination overlapping in project members table. Nice work!
2201.mov
aaryaneil
approved these changes
Apr 27, 2024
Contributor
aaryaneil
left a comment
aaryaneil
left a comment
There was a problem hiding this comment.
Tested the PR and the pagination doesn't overlap when the screen size is reduced.
Screen.Recording.2024-04-27.at.7.25.30.AM.mov
MinSun0814
approved these changes
May 2, 2024
MinSun0814
left a comment
MinSun0814
left a comment
There was a problem hiding this comment.
There is no overlapping when resizing the window now.
Screen.Recording.2024-05-02.at.13.09.16.mov
TareqMia
approved these changes
May 12, 2024
Contributor
TareqMia
left a comment
TareqMia
left a comment
There was a problem hiding this comment.
Changes look good and there is no overlap when making the screen size smaller 👍
Screen.Recording.2024-05-12.at.1.21.29.AM.mov
peter6866
approved these changes
May 25, 2024
Contributor
peter6866
left a comment
peter6866
left a comment
There was a problem hiding this comment.
Hi, I have reviewed your PR and it works with smaller screen sizes.
one-community
added
Needs New Developer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pagination Overlaps with table values.
Related PRS (if any):
N/A
…
Main changes explained:
How to test:
npm installand...to run this PR locallyScreenshots or videos of changes:
Before -
Screen.Recording.2024-03-23.at.10.56.25.AM.1.mov
After -
Screen.Recording.2024-04-26.at.3.57.35.PM.mov