Skip to content

Conversation

@Annezhang673
Copy link
Contributor

Description

Screen Shot 2024-09-07 at 12 17 03 PM Screen Shot 2024-09-07 at 12 17 12 PM

Related PRS (if any):

For backend use development branch
Previous PR PR #2005

Main changes explained:

  • Update file PeopleTableDetails.css

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log in as an admin user
  5. Add multiple tasks (combine with both short task name and long task name) for User A following this instruction. (make sure to add task hours)
  6. go to dashboard→ reports→ people->User A (who has been assigned with tasks with one or more longer task names)
  7. Check there's no text overlap between columns.
  8. Check the "End Date," is not moved under the first column, "Task," when resizing the screen.

Screenshots or videos of changes:

Please refer to the following video for the bugs fixed. Note that I have already created the tasks and assigned to testing account prior.

video1820018236.mp4

Note:

Include the information the reviewers need to know.

@netlify
Copy link

netlify bot commented Sep 7, 2024

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 4ca74ac
🔍 Latest deploy log https://app.netlify.com/sites/highestgoodnetwork-dev/deploys/66dbd729eff2ad0008adc551
😎 Deploy Preview https://deploy-preview-2650--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

jinxyou
jinxyou previously approved these changes Sep 7, 2024
Copy link
Contributor

@jinxyou jinxyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UI fix seems to be working fine. Great work!
Screenshot 2024-09-06 222455
Screenshot 2024-09-06 222505
Screenshot 2024-09-06 222519

linkhanthtel
linkhanthtel previously approved these changes Sep 7, 2024
Copy link

@linkhanthtel linkhanthtel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Texts are no longer overlap for screen size (375px and above). Nice work!

PR #2650 PR #2650 (2)

AJAYINAVOLU
AJAYINAVOLU previously approved these changes Sep 7, 2024
Copy link
Contributor

@AJAYINAVOLU AJAYINAVOLU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are working as expected.

image

Thank You

mohangadde1
mohangadde1 previously approved these changes Sep 7, 2024
Copy link
Contributor

@mohangadde1 mohangadde1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
working as expected, no overlapping of text.

CillianRen
CillianRen previously approved these changes Sep 7, 2024
Copy link
Contributor

@CillianRen CillianRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
The UI changes works great

SMitta11
SMitta11 previously approved these changes Sep 7, 2024
Copy link

@SMitta11 SMitta11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this and it works as expected .
But I have added 3 tasks for this user and it is showing only 2. It am not sure if it is related to this PR but could you please check if this expected result.
Screenshot:
Screen Shot 2024-09-07 at 6 49 27 PM
Screen Shot 2024-09-07 at 6 51 08 PM

Jingyii800
Jingyii800 previously approved these changes Sep 8, 2024
Copy link
Contributor

@Jingyii800 Jingyii800 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this feature and it worked as expected. Even though the task name is very long, the text won't overlap.

bandicam.2024-09-07.19-50-02-433.mp4

vishavk1992
vishavk1992 previously approved these changes Sep 10, 2024
Copy link
Contributor

@vishavk1992 vishavk1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have tested this PR and it works as expected

Screenshot 2024-09-10 154344

Copy link

@nikhilpittala16 nikhilpittala16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the PR and everything works as expected.

PR.vid.32.mp4

@KurtisIvey
Copy link
Contributor

Hi Anne, I noticed there were merge conflict on this. Looks like it's just a CSS thing, but we'd love to get this moved to final review asap once it's cleared up

Copy link
Member

@one-community one-community left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR overlapped with this one. Please carefully fix conflicts and add this into your PR too:
image

Watchdog00
Watchdog00 previously approved these changes Sep 20, 2024
Copy link
Contributor

@Watchdog00 Watchdog00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have completed the testing and got the expected results. Good job!
#2650

@navya9989
Copy link

I have tested this PR and Everything is working as Expected
2650 #PR

@netlify
Copy link

netlify bot commented Oct 19, 2024

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 31160db
🔍 Latest deploy log https://app.netlify.com/sites/highestgoodnetwork-dev/deploys/6713196e6712dd000828f71b
😎 Deploy Preview https://deploy-preview-2650--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@one-community
Copy link
Member

Thank you all, merging!

@one-community one-community merged commit d03f73b into development Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.