Yili - Gives the user permission to Reset and/or Change the password of any user by suaniii · Pull Request #2860 · OneCommunityGlobal/HighestGoodNetworkApp

suaniii · 2024-11-12T20:57:52Z

Description

Related PRS

This frontend PR is related to the backend PR #1146

How to test:

check into current branch
do npm install and ... to run this PR locally
Clear site data/cache
log as owner user
go to Other Links -> Permissions Management -> Manage User Permissions -> Choose a volunteer user -> add Reset / Change Password (Others) -> click on "save changes"
verify that the user who was given the permission is now able to see the reset password button and reset another volunteer user's password.(make sure to reset your own account for testing)

Screenshots or videos of changes:

0.mov

netlify · 2024-11-12T20:58:07Z

✅ Deploy Preview for highestgoodnetwork-dev ready!

Name	Link
🔨 Latest commit	`c57d75b`
🔍 Latest deploy log	https://app.netlify.com/sites/highestgoodnetwork-dev/deploys/67f61e9882f80b0008cbac41
😎 Deploy Preview	https://deploy-preview-2860--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

manikittu810

Hello @suaniii
Everything is working as mentioned.
Thank you.

audreydieuanh

My volunteer account was able to see the reset button after I changed the permission with my admin test account.

anji-annavarapu

v1.mov

its working all expected.

srikanthpusthem

working as expected

honglinchen0524

Great work! I was able to give permission and see the reset password button. Video below:

PR2860.mp4

lycan10 · 2025-01-24T02:53:19Z

Hi, unfortunately, I cannot find the option to reset password.

yany960

Tested successfully—assigned permissions correctly enable the user to see and use the reset password button. The functionality works as expected.

Peter-Nie2003

The function work as expected, Well done!

Screen.Recording.2025-02-08.at.9.24.19.AM.mov

AurHubertMax

The permission to reset/change password of a user functions as expected. Gave permission to my volunteer 1 account to change password of any user, verified to see that the button to reset the password of my volunteer 2 account is available. Changed the account's password to a new password, and verified that the changes were in effect by logging into my volunteer 2 account with the new password.

z.PR.2860.proof.1.mp4

HarideepValiveru · 2025-03-16T02:11:16Z

Reviewed PR. The code looks really good and shows a lot of effort in organizing everything. It takes care of managing user profiles, teams, permissions, and other tasks well. The tabs and modals are really cool features.

karnati007

Tested the Reset / Change Password (Others) permission in Other Links → Permissions Management → Manage User Permissions as an owner user. Added the permission to a volunteer user, saved changes, and confirmed that the user could see the reset password button and successfully reset another volunteer user's password. Also tested by resetting my own account. Cleared site data and cache before testing. Everything is working as expected.

nathanah

Should consolidate update and reset password permissions.

nathanah · 2025-04-02T22:01:46Z

src/components/UserProfile/UserProfile.jsx

      const response = await axios.get(ENDPOINTS.USER_PROFILE(userId));
      const currentUserEmail = response.data.email;
      dispatch(setCurrentUser({ ...props.auth.user, email: currentUserEmail }));
+      setCanResetPassword(response.data.permissions.frontPermissions.includes('resetPassword'));


Suggested change

setCanResetPassword(response.data.permissions.frontPermissions.includes('resetPassword'));

const canResetPassword = props.hasPermission('resetPassword');

hasPermission() checks both role and individual permissions. The current way only checks individual permissions. Doesn't need to be a state obj because it won't change after being set.

Changed to use updatePassword permission instead.

nathanah · 2025-04-02T22:07:36Z

src/components/UserProfile/UserProfile.jsx

            </TabContent>
            <div className="profileEditButtonContainer">
-              {canUpdatePassword && canEdit && !isUserSelf && (
+              {(canUpdatePassword && canEdit && !isUserSelf || canResetPassword) && (


Doesn't updatePassword already do what resetPassword should do?

Fixed, canUpdatePassword is now being used for this.

nathanah · 2025-04-02T22:15:00Z

src/components/PermissionsManagement/PermissionsConst.js

      },
+      {
+        label: 'Reset / Change Password (Others)',
+        key: 'resetPassword',


I think the updatePassword permission was already mostly set up, but not included in PermissionsConst.js. Should be fixing/replacing updatePassword instead of adding a new permission of resetPassword on top of it.

I've removed resetPassword from both BE and FE, and updatePassword is doing the job now.

src/components/UserManagement/UserTableData.jsx

nathanah · 2025-04-05T23:15:08Z

src/components/UserProfile/UserProfile.jsx

  const [showToggleVisibilityModal, setShowToggleVisibilityModal] = useState(false);
  const [pendingRehireableStatus, setPendingRehireableStatus] = useState(null);
  const [isRehireable, setIsRehireable] = useState(null);
+  const [canUpdatePassword, setCanUpdatePassword] = useState(props.hasPermission('updatePassword'));


Suggested change

const [canUpdatePassword, setCanUpdatePassword] = useState(props.hasPermission('updatePassword'));

Removed this, use hasPermission() instead.

nathanah · 2025-04-05T23:15:10Z

src/components/UserProfile/UserProfile.jsx

      const response = await axios.get(ENDPOINTS.USER_PROFILE(userId));
      const currentUserEmail = response.data.email;
      dispatch(setCurrentUser({ ...props.auth.user, email: currentUserEmail }));
+      setCanUpdatePassword(response.data.permissions.frontPermissions.includes('updatePassword'));


Suggested change

setCanUpdatePassword(response.data.permissions.frontPermissions.includes('updatePassword'));

This doesn't check role permissions.

Removed this, use hasPermission() instead.

nathanah · 2025-04-05T23:16:13Z

src/components/UserProfile/UserProfile.jsx

  const canChangeUserStatus = props.hasPermission('changeUserStatus');
  const canAddDeleteEditOwners = props.hasPermission('addDeleteEditOwners');
  const canPutUserProfile = props.hasPermission('putUserProfile');
-  const canUpdatePassword = props.hasPermission('updatePassword');


This is how it should be done. canUpdatePassword doesn't need to be a state object and should always be set to props.hasPermission('updatePassword').

Reverted my changes, now it's using hasPermission()

nathanah

LGTM

one-community · 2025-04-13T05:11:00Z

Thank you all, merging!

suaniii mentioned this pull request Nov 12, 2024

Yili - Gives the user permission to Reset and/or Change the password of any user OneCommunityGlobal/HGNRest#1146

Merged

manikittu810 previously approved these changes Nov 15, 2024

View reviewed changes

audreydieuanh approved these changes Nov 17, 2024

View reviewed changes

anji-annavarapu approved these changes Nov 18, 2024

View reviewed changes

Hritvik111 added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Nov 23, 2024

srikanthpusthem approved these changes Jan 17, 2025

View reviewed changes

honglinchen0524 previously approved these changes Jan 18, 2025

View reviewed changes

yany960 previously approved these changes Feb 6, 2025

View reviewed changes

Peter-Nie2003 previously approved these changes Feb 8, 2025

View reviewed changes

AurHubertMax previously approved these changes Feb 19, 2025

View reviewed changes

karnati007 previously approved these changes Apr 2, 2025

View reviewed changes

nathanah requested changes Apr 2, 2025

View reviewed changes

fix reset pass

5debe3d

suaniii dismissed stale reviews from karnati007, AurHubertMax, Peter-Nie2003, yany960, honglinchen0524, and manikittu810 via 5debe3d April 5, 2025 06:49

suaniii force-pushed the yili_fix_reset_password branch from 319eed6 to 5debe3d Compare April 5, 2025 06:49

suaniii added 3 commits April 5, 2025 02:29

resolve comments

34ad733

fix ut

f1a62d5

fix ut

593597a

suaniii requested a review from nathanah April 5, 2025 13:19

nathanah requested changes Apr 5, 2025

View reviewed changes

suaniii force-pushed the yili_fix_reset_password branch from c14fba2 to 593597a Compare April 9, 2025 03:14

remove state, use props

c57d75b

suaniii requested a review from nathanah April 9, 2025 23:55

nathanah approved these changes Apr 12, 2025

View reviewed changes

one-community merged commit a62c099 into development Apr 13, 2025
6 checks passed

one-community mentioned this pull request Apr 13, 2025

Frontend Release to Main [4.11] #3410

Merged

	setCanResetPassword(response.data.permissions.frontPermissions.includes('resetPassword'));
	const canResetPassword = props.hasPermission('resetPassword');

Uh oh!

Conversation

suaniii commented Nov 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related PRS

How to test:

Screenshots or videos of changes:

Uh oh!

netlify bot commented Nov 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for highestgoodnetwork-dev ready!

Uh oh!

manikittu810 left a comment

Choose a reason for hiding this comment

Uh oh!

audreydieuanh left a comment

Choose a reason for hiding this comment

Uh oh!

anji-annavarapu left a comment

Choose a reason for hiding this comment

Uh oh!

srikanthpusthem left a comment

Choose a reason for hiding this comment

Uh oh!

honglinchen0524 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lycan10 commented Jan 24, 2025

Uh oh!

yany960 left a comment

Choose a reason for hiding this comment

Uh oh!

Peter-Nie2003 left a comment

Choose a reason for hiding this comment

Uh oh!

AurHubertMax left a comment

Choose a reason for hiding this comment

Uh oh!

HarideepValiveru commented Mar 16, 2025

Uh oh!

karnati007 left a comment

Choose a reason for hiding this comment

Uh oh!

nathanah left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

suaniii Apr 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nathanah Apr 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

suaniii Apr 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nathanah left a comment

suaniii commented Nov 12, 2024 •

edited

Loading

netlify bot commented Nov 12, 2024 •

edited

Loading

honglinchen0524 left a comment •

edited

Loading

suaniii Apr 9, 2025 •

edited

Loading

nathanah Apr 5, 2025 •

edited

Loading

suaniii Apr 9, 2025 •

edited

Loading