Skip to content

Conversation

@CodewithKoushica
Copy link
Contributor

@CodewithKoushica CodewithKoushica commented Feb 21, 2025

Description

Screenshot 2025-02-20 at 9 20 30 PM Screenshot 2025-02-20 at 9 20 59 PM

Related PRS (if any):

This frontend PR is related to the #1241 backend PR.
To test this frontend PR you need to checkout the #1241 backend PR.

Main changes explained:

  • Increased the titleCode character limit from 5 to 7.
  • Trimmed the media link to prevent errors.
  • Fixed inconsistency between the displayed tiles of titleCodes and the titleCode shown in the edit modal by adding:
    const titleCode = titleData?.titleCode ? titleData.titleCode : titleData.titleName.slice(0, 7);

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as admin user
  5. go to User Profile→ Quick Setup Codes
  6. Navigate to User Profile → Quick Setup Codes.
  7. Edit or add a new title and verify that it:
  • Accepts special characters.
  • Allows spaces between characters.
  • Requires at least one uppercase or lowercase letter.
  • Maintains titleCode consistency between the tile display and the edit modal.

@netlify
Copy link

netlify bot commented Feb 21, 2025

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 6874826
🔍 Latest deploy log https://app.netlify.com/sites/highestgoodnetwork-dev/deploys/67b8ac93f2d62700085bd6eb
😎 Deploy Preview https://deploy-preview-3181--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@one-community one-community merged commit 519649e into development Feb 21, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants