Skip to content

Yili - unit test : WeeklySummariesReport /FormattedReport#3252

Merged
one-community merged 1 commit into
developmentfrom
yili_unit_test_formatted_report
Apr 6, 2025
Merged

Yili - unit test : WeeklySummariesReport /FormattedReport#3252
one-community merged 1 commit into
developmentfrom
yili_unit_test_formatted_report

Conversation

@suaniii
Copy link
Copy Markdown
Contributor

@suaniii suaniii commented Mar 9, 2025

Description

Unit test for src/components/WeeklySummariesReport /FormattedReport

Main changes explained:

New file: FormattedReport.test.js : unit test cases

How to test:

  1. check into current branch
  2. do npm run test FormattedReport.test.js
  3. check if all the test cases pass

Screenshots or videos of changes:

1

@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 9, 2025

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit b04603c
🔍 Latest deploy log https://app.netlify.com/sites/highestgoodnetwork-dev/deploys/67cd2e60491ef100089bcedd
😎 Deploy Preview https://deploy-preview-3252--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rnavyaprabha rnavyaprabha self-requested a review March 9, 2025 07:31
Copy link
Copy Markdown

@rnavyaprabha rnavyaprabha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have checked the code changes and also saw all the test cases written, it looks good to me .Also all the test cases passed, here is the screenshot from my local system:
image

Copy link
Copy Markdown
Contributor

@barnaboss305 barnaboss305 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests pass when I run the script.
PR 3252

Copy link
Copy Markdown
Contributor

@vasavi-139 vasavi-139 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests passed when I ran the script, and here is the screenshot from my local system for reference.
Screenshot 2025-03-10 163856

Copy link
Copy Markdown
Contributor

@Nayakar-Rohith Nayakar-Rohith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed this PR and successfully ran the unit tests for WeeklySummariesReport/FormattedReport. All test cases passed without any issues, and the implementation looks good. Approving this PR.
Screenshot 2025-03-12 145406

@brn8 brn8 assigned brn8 and unassigned brn8 Mar 12, 2025
@brn8
Copy link
Copy Markdown
Contributor

brn8 commented Mar 12, 2025

I ran npm test FormattedReport.test.js, and all tests passed successfully with no errors. The test coverage looks good, and everything is functioning as expected.
image

@brn8 brn8 self-requested a review March 12, 2025 22:49
@Akhilguntur2801
Copy link
Copy Markdown

I have tested this PR and all the test cases passed successfully and the test coverage is good.
image

@vikasreddynomula vikasreddynomula self-requested a review March 16, 2025 05:45
Copy link
Copy Markdown

@vikasreddynomula vikasreddynomula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

The code looks good and all the test cases are cleared approving this PR

Copy link
Copy Markdown
Contributor

@nikhilrouth nikhilrouth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and tested. All unit test cases pass as expected. Verified that the FormattedReport component correctly handles different scenarios. Everything works as expected so approving this PR 3252.

Screenshot 2025-03-20 at 5 02 35 PM

@beblicarl beblicarl self-requested a review March 21, 2025 10:26
@beblicarl
Copy link
Copy Markdown
Contributor

All tests passed successfully and the code is great

image

@pdp5 pdp5 self-requested a review March 22, 2025 17:59
Copy link
Copy Markdown
Contributor

@pdp5 pdp5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have thoroughly tested the defined steps and ran all the test cases, all of which passed successfully. Therefore, I am approving this PR.

Test Cases

Copy link
Copy Markdown
Contributor

@KurtisIvey KurtisIvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-03-22 at 11 21 03 PM

Test looks to cover the essentials we'd need for this component and everything functions as intended. You cover ensuring key elements appear, role based rendering, missing data, and link handling properly.

Copy link
Copy Markdown

@nikhilpittala16 nikhilpittala16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested PR and all the text cases have passed.
image

@one-community
Copy link
Copy Markdown
Member

Thank you all, merging!

@one-community one-community merged commit 56827df into development Apr 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.