Vinay: Let a user know through a popup that Permissions have been changed for them#3294
Conversation
…ighestGoodNetworkApp into vinay/notify-user-new-permission
…n added" This reverts commit 0922fe7.
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
angad363
left a comment
angad363
left a comment
There was a problem hiding this comment.
I reviewed the code changes and followed the testing steps as outlined in the PR description. I checked out the "vinay/notify-user-new-permission" branch and logged in using an Owner account. I navigated to "Other Links" → "Permission Management" → "Manage User Permission," made changes to the permissions for two accounts (Angad Dev and Angad Test), and saved the updates. However, after logging into both of these accounts, the yellow popup notification about permission changes did not appear as demonstrated in the video. Additionally, I encountered an error message in the console (screenshot attached). Please review and address these issues before proceeding with the approval.
PR.3294.mp4
|
Additionally, I am not being able to edit user permissions using an administrator account. Only, reset to default button works in an admin account. |
|
Hi @angad363 |
…ighestGoodNetworkApp into vinay/notify-user-new-permission
Amalesh-A
left a comment
Amalesh-A
left a comment
There was a problem hiding this comment.
I am trying to review this PR and I can't change the permissions for the testing account even though I am using an admin account. Am I missing something?
But, when I click submit on the changes, I can see the header on the account that has received the "changed" permissions.
So, it turns out that it works for Owner accounts and not Admin accounts.
As an owner, I was able to change permissions and a pop-up was alerted on the affected account.
…ighestGoodNetworkApp into vinay/notify-user-new-permission
one-community
added
the
High Priority - Please Review First
|
I couldn't fully test this feature because permissions aren't editable using the admin account, and the owner account isn't available to me.
|
manushajyasta30
left a comment
manushajyasta30
left a comment
There was a problem hiding this comment.
Hi Vinay,
I have cloned both of your working branches and followed the given steps. I have logged in as owner and added a permission to a user. I cleared the cache, and after logging in with the user account, I'm able to see the yellow message successfully. Good work!
karnati007
left a comment
karnati007
left a comment
There was a problem hiding this comment.
Tested the 'notify-user-new-permission' feature by modifying permissions for another user. Upon logging into the edited account, the expected 'Heads Up' notification appeared correctly on the first login post-change. Functionality works as expected.
vamsikrishna1704
left a comment
vamsikrishna1704
left a comment
There was a problem hiding this comment.
Hi @vinayv-456 ,
I have reviewed the PR by running the application locally following the instructions mentioned in the description. I have noticed the display of the pop up notification below the navigation bar to show the user's that their permissions changed when they logged in first time after changes. I would approve the PR to be merged into the main. Thank You.
|
Reviewed the frontend changes for displaying the permission update notification modal. The message appears correctly when logging in after a permission change and disappears after acknowledgment. Verified that the modal shows only once, doesn’t reappear on refresh, and is scoped to the correct user. Tested across both light and dark modes, and confirmed the modal styling and logic are working as expected. A solid addition to improve communication of role changes in the UI. |
sravankumarbodakonda
left a comment
sravankumarbodakonda
left a comment
There was a problem hiding this comment.
I followed the steps: logged in as an admin/owner, navigated to Other Links > Permission Management > Manage User Permission, made some changes to another account's permissions, and submitted the changes. However, after logging into the updated account, the expected popup—‘Heads up, there were permission changes made to this account’—did not appear on the first login as expected.
Hi @sravankumarbodakonda , |
vinayv-456
dismissed stale reviews from vamsikrishna1704, manushajyasta30, and Amalesh-A
via
26ab563
|
Thank you all, merging! |
10 participants
Description
If an account changes permissions for another account, then when the account which has permissions edited, logs in, there should be a popup letting them know that permissions have been edited in this account. Only should happen for the first time the user logs into account after permissions were edited.
Related PRS (if any):
This frontend PR is related to the #1278 backend PR.
…
Main changes explained:
…
How to test:
Screenshots or videos of changes:
video1858768607.mp4
Note:
Include the information the reviewers need to know.