Skip to content

Nikita weekly company summary email#3316

Closed
ArtemisNyx3 wants to merge 7 commits intodevelopmentfrom
nikita-weekly-company-summary-email
Closed

Nikita weekly company summary email#3316
ArtemisNyx3 wants to merge 7 commits intodevelopmentfrom
nikita-weekly-company-summary-email

Conversation

@ArtemisNyx3
Copy link
Contributor

@ArtemisNyx3 ArtemisNyx3 commented Mar 26, 2025

Description

image

Related PRS (if any):

This frontend PR is related to the #1291backend PR.

Main changes explained:

  • Added a Total Summary Email page under reports tab
  • Updated Login.jsx to be helpful for puppeteer
  • Updated AccordianWrapper.jsx to be helpful for puppeteer

How to test:

  1. check into current branch
  2. do npm install and npm i to run this PR locally
  3. Clear site data/cache
  4. log as admin user
  5. Follow Backend Steps
  6. go to dashboard→ Tasks→ Total Org Summary Email
  7. Enter your email address and verify if you are getting the screenshot of the 'Total Org Summary' Dashboard. The contents of the attachment are not in the scope of this PR,
    i. Verify if you are getting all the graphs in the email attachment
    ii. if they are loaded (This depends on the performance of your system. Feel free to increase timeout value in reportsController. js
    The timeout is set to 50 sec it should be adequate
    image

Screenshots or videos of changes:

image
The email looks something like this
image
The attachment
image

Note:

I appreciate your patience 💖

@netlify
Copy link

netlify bot commented Mar 26, 2025

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 5b94b00
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/6934b788e1fc0d0008d3047e
😎 Deploy Preview https://deploy-preview-3316--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@one-community one-community added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Mar 31, 2025
Copy link
Contributor

@cgomezhub cgomezhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the function is general working but the subjt and message that is sending are diferents to the backend code
Screenshot 2025-04-05 073227
Screenshot 2025-04-05 070701
Screenshot 2025-04-05 070822
Screenshot 2025-04-05 070416

@Dharmik1710
Copy link
Contributor

Reviewed the code changes for the Total Org Summary Email feature. The form structure, field validation, and submission logic are clearly implemented, and the flow integrates well with the existing dashboard components.

I was not able to test the end-to-end functionality due to the requirement of setting up a GCP account with billing details, but the frontend logic and UI implementation appear consistent with the intended behavior described in the PR.

The component looks well-structured and aligns with the expected admin workflow.

@ArtemisNyx3 ArtemisNyx3 requested a review from cgomezhub April 20, 2025 09:24
Copy link
Contributor

@naiduajaykumar naiduajaykumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had followed every step what I understand in the description but it doesn't work for me. When I enter the recipient email its getting failed and getting 500 Error code. Can you please include testing steps clearly. Thank you.
Screenshot 2025-07-10 162426

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 6, 2025

Copy link

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Nikita,

I have tried to review your PR locally and did all the changes you have mentioned and even updated the REACT_FRONTEND_URL = http://localhost:5173 in backend env still have unable to receive an email. It keeps saying "Failed to send email." Do let me know if i am missing any step. I have added my email as recipient and have not touched any Puppeteer logic.
Screenshot 2025-12-18 at 8 16 36 PM
Screenshot 2025-12-18 at 8 16 53 PM
Screenshot 2025-12-18 at 8 17 07 PM
Screenshot 2025-12-18 at 8 13 59 PM

@one-community one-community added Needs New Developer This is a PR that is partially developed but needs someone new to take it over and finish it. do not review Do not review or look at code without full context and removed High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible labels Dec 23, 2025
Copy link
Contributor

@DiyaWadhwani DiyaWadhwani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I was able to receive the email. For anyone else reviewing this PR, please ensure you update your 'const uri' to the latest in the below-mentioned files:
db.js, addMembersToTeams.js, addNewField.js

On the other hand, the total org summary in general doesn't work so the attachment in the email is of a 'Something went wrong' and the 'Refresh Page' button.
The rest works as expected. Attached video below.
https://github.com/user-attachments/assets/071d6edb-25be-438b-a78a-aad27f205713

Also added myself as a recipient and tried sending an email from the frontend. That works too.
Screenshot 2025-12-27 at 1 44 32 AM

Overall, the main functionality works but needs a lot of new updates in the code, since it is pretty old.

@DiyaWadhwani
Copy link
Contributor

Created a new PR set with updated dev code changes - #2090; #4953

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not review Do not review or look at code without full context Needs New Developer This is a PR that is partially developed but needs someone new to take it over and finish it.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants