Skip to content

Brijesh_fix_button_layout#3336

Merged
one-community merged 1 commit into
developmentfrom
Brijesh_fix_button_layout
Mar 30, 2025
Merged

Brijesh_fix_button_layout#3336
one-community merged 1 commit into
developmentfrom
Brijesh_fix_button_layout

Conversation

@brn8
Copy link
Copy Markdown
Contributor

@brn8 brn8 commented Mar 28, 2025

Description

A recent PR unintentionally altered the button layout across multiple pages.
image
image
image

Related PRS (if any):

This frontend PR is not related to any backend PR

Main changes explained:

This update ensures the button layout appears as intended by implementing the necessary code to maintain consistency and correct styling across all affected pages.

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as admin user
  5. go to other Links → permissions management
  6. verify that all the buttons are correctly styled according to the expected design.

Screenshots or videos of changes:

Photo2 Photo1 Photo3

Note:

Include the information the reviewers need to know.

@brn8 brn8 added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Mar 28, 2025
@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 28, 2025

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit ae181db
🔍 Latest deploy log https://app.netlify.com/sites/highestgoodnetwork-dev/deploys/67e71f224c8b4f00074912d6
😎 Deploy Preview https://deploy-preview-3336--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Copy Markdown

@palankigreeshma1109 palankigreeshma1109 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Followed all the steps that you mentioned and found these styles are working as expected.
Below are the screenshots attached for your reference.
Screenshot (19)

Screenshot (20)

Copy link
Copy Markdown
Contributor

@vamsikrishna1704 vamsikrishna1704 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @brn8,
I have reviewed the PR and followed the instruction in locally running the application. I have seen the layout changed to the previous layout. I have also verified the layout of the other features those effected by the changes, those are looking good. Thank you.
ButtonIssueFix

Copy link
Copy Markdown
Contributor

@pavanputti pavanputti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in this PR effectively address the unintended layout issues caused by the recent PR. The implementation correctly restores the button layout consistency and styling across all impacted pages. I have tested the changes locally, following the instructions provided, and confirmed that the button styles are now aligned with the expected design.
Screenshot 2025-03-29 at 1 50 35 AM
Screenshot 2025-03-29 at 1 51 32 AM
Screenshot 2025-03-29 at 1 52 10 AM

@Dharmik1710
Copy link
Copy Markdown
Contributor

I tested the button layout fix and verified that all buttons appear as intended across the affected pages. The Permissions Management section now maintains consistent button styling. I have also checked out in dark and light mode.

Local setup

Browser: Google chrome Version 134.0.6998.166
Role: Admin

PR 3336 Permission Management PR 3336 Task Suggestions

Copy link
Copy Markdown
Contributor

@linh2020 linh2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve reviewed and tested this PR both through Netlify and locally. The button layout issue that was unintentionally introduced by a previous PR has been fixed.

  • Verified changes in the “Permissions Management” section and other affected pages.
  • Styling now aligns with the original design.
  • Layout is consistent, responsive, and visually correct.

Excellent work @brn8. Marking this PR as approved.

2025-03-29 00_59_02-Permissions Management - Your Microsoft Edge - Microsoft​ Edge

2025-03-29 00_59_58-Dashboard - Linh Admin - Your Microsoft Edge - Microsoft​ Edge

Copy link
Copy Markdown

@rsripathi2906 rsripathi2906 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the PR locally by following the provided instructions. Verified that the button layout appears as intended, and the changes have restored the previous layout. Also checked other affected features, and everything looks good.
Screenshot 2025-03-29 125700
Screenshot 2025-03-29 125815

@pdp5 pdp5 self-requested a review March 29, 2025 18:30
@humemah
Copy link
Copy Markdown
Contributor

humemah commented Mar 29, 2025

Tested the changes, and the button layout is now consistent across all affected pages. Everything looks good.
image
image

Copy link
Copy Markdown
Contributor

@pdp5 pdp5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed your pull request and followed all the testing steps to verify that the button layouts on the Dashboard page, Task Edit Suggestions page, and Permission Management page are correctly fixed. Therefore, I am approving your pull request.

PR3336-Picture1
PR3336-Picture2
PR3336-Picture3

@manushajyasta30 manushajyasta30 self-requested a review March 29, 2025 21:13
Copy link
Copy Markdown
Contributor

@manushajyasta30 manushajyasta30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the UI is displayed as expected. Good work.

image

Copy link
Copy Markdown
Contributor

@vaibhavkoladiya vaibhavkoladiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the PR by checking out the current branch, running npm install and starting the app. Cleared site data/cache and logged in as admin. Navigated to Other Links → Permissions Management and verified that all buttons are styled correctly as per the expected design. Looks good — approving the PR.

Screenshot 2025-03-29 142902
Screenshot 2025-03-29 143252
Screenshot 2025-03-29 143409

Copy link
Copy Markdown

@akanksha7 akanksha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the changes and all the buttons are correctly styled according to the expected design. The buttons are also aligned properly on different screen sizes.
Screenshot 2025-03-29 at 7 09 24 PM

@one-community
Copy link
Copy Markdown
Member

Thank you all, merging!

@one-community one-community merged commit 0283567 into development Mar 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible Moved to Final Review

Projects

None yet

Development

Successfully merging this pull request may close these issues.