Rohith | Fix dropdown options visibility in Weekly Summaries report#3358
Merged
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rsripathi2906
previously approved these changes
Apr 3, 2025
rsripathi2906
left a comment
There was a problem hiding this comment.
Checked out the branch, ran npm install, and tested the fix locally. The dropdown in the Weekly Summaries Report now displays all options correctly, with proper scrolling behavior. No cutoff at 4 items, and everything works as expected in both light and dark mode.
Screen.Recording.2025-04-03.125551_1.mp4
nikhilpittala16
previously approved these changes
Apr 4, 2025
nikhilpittala16
left a comment
There was a problem hiding this comment.
I have tested the PR and everything works as expected.
PR.vid.11.mp4
palankigreeshma1109
previously approved these changes
Apr 5, 2025
…ighestGoodNetworkApp into Rohith_fix_dropdown_limit
…ighestGoodNetworkApp into Rohith_fix_dropdown_limit
69d8541
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
This PR resolves an issue in the Weekly Summaries Report screen where the dropdown component (used to select team codes and colors) was only showing 4 options. The issue was introduced after the styling was migrated to SCSS modules. The original .options class was no longer applying due to CSS scoping in modules, which limited the dropdown height and visibility. A fix was implemented by using the :global selector inside the .multiSelectFilter class to properly target the .options dropdown container.
Fixes # (bug list priority medium 2.4.3)
Related PRS (if any):
None
…
Main changes explained:
…
How to test:
npm installand...to run this PR locallyAll options are visible
Scroll works correctly
The dropdown doesn’t cut off at 4 items
Works in dark mode
Screenshots or videos of changes:
Before:
https://www.loom.com/share/129be3455a0c48218d884e9466a9103a?sid=b6e818df-e50a-499d-bc0a-843bf1acbcd4
After:
https://www.loom.com/share/450bfb08a49c45bfaeddd7d4ae006971?sid=91dcbd6d-cf5d-4f2b-9fc4-fd5e0d6413e8
Note:
The fix was confirmed to work using the :global selector in SCSS module, allowing the dropdown to display the full list with custom scrollbar styling. No functional code was modified, only scoped styles were corrected.