Skip to content

Angad - Hotfix broken teams page formatting and team members not visible.#3366

Merged
one-community merged 12 commits into
developmentfrom
Angad_fix_members_modal_formatting_visibility_alignment
Apr 9, 2025
Merged

Angad - Hotfix broken teams page formatting and team members not visible.#3366
one-community merged 12 commits into
developmentfrom
Angad_fix_members_modal_formatting_visibility_alignment

Conversation

@angad363
Copy link
Copy Markdown
Contributor

@angad363 angad363 commented Apr 4, 2025

Description

There was a bug introduced last week where the Team Members of a particular team were not visible when a user clicks on the team members button. Detailed information about the bug:

image

Related PRS (if any):

This bug was introduced because of the frontend PR #3168

This PR is related to development branch in backend.

Main changes explained:

  • Changed and reverted the logic of team members visibility in popup.
  • Changed the CSS to align everything as per requirements.
  • Fixed Delete button style to accommodate long team members' names.
  • Fixed the Active team members slider (default is Active and slider is green).
  • Fixed the Teams overview cards and resized them and made them accommodate more than three digit team numbers.
  • Fixed the style of team members in the popup.

How to test:

  1. check into current branch
  2. do npm install and npm run start:local to run this PR locally
  3. Clear site data/cache
  4. log as admin or owner user
  5. go to dashboard→ Other Links→ Teams
  6. Verify if the alignment of the elements is proper.
  7. Click on the members button of a team and verify if the team members are visible.
  8. Check if you are able to add team members in the team.
  9. Check if delete button text doesn't wrap if team member name is too long.
  10. Check the team overview cards have been resized and are looking clean.
  11. Check if edit-delete buttons in teams table look like below in screenshot.
  12. Verify if team members, team member numbers, active status, toggle switch and date added are aligned and in same line.
  13. Verify the active status slider is green by default and are able to change the status by clicking and moving mouse left and right (Right : Inactive (Grey), Middle : Active (Green), Left : See All (Blue)).

Screenshots or videos of changes:

Teams Overview 1

PR #3366

PR #3366 - 2

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 4, 2025

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 369920e
🔍 Latest deploy log https://app.netlify.com/sites/highestgoodnetwork-dev/deploys/67f5d0e05769b30008cfb8eb
😎 Deploy Preview https://deploy-preview-3366--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@angad363 angad363 added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Apr 4, 2025
@manushajyasta30 manushajyasta30 self-requested a review April 4, 2025 21:46
nikhilpittala16
nikhilpittala16 previously approved these changes Apr 4, 2025
Copy link
Copy Markdown

@nikhilpittala16 nikhilpittala16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the PR and everything works as expected.

PR.vid.7.mp4

Copy link
Copy Markdown
Contributor

@manushajyasta30 manushajyasta30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes work as expected. alignment of the elements is proper. Clicked on the members button of a team and verified the team members are visible. able to add team members in the team. delete button text is not wrapped if team member name is too long.

Requesting to clean up the code (remove the commented code and console.logs if possible.)

image

@angad363 angad363 removed the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Apr 4, 2025
@angad363 angad363 marked this pull request as draft April 4, 2025 22:28
myeeli
myeeli previously approved these changes Apr 5, 2025
Copy link
Copy Markdown
Contributor

@myeeli myeeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The teams table is aligned properly and i was bale to view the team members when I'm trying to see the team members. I was able to add new team member and if the team member name is very large the delete button text is not wrapped. Everything is working well with varying screen sizes.

Suggestion: While deleting a user it would be better if a pop up comes up to confirm if the user should be deleted or not.

PR 3366 - 1 PR 3366 - 2 PR 3366 - 3 PR 3366 - 4

@angad363 angad363 added the do not review Do not review or look at code without full context label Apr 5, 2025
@angad363 angad363 marked this pull request as ready for review April 6, 2025 01:48
@angad363 angad363 dismissed stale reviews from myeeli and nikhilpittala16 via 78ced25 April 6, 2025 01:49
@angad363 angad363 removed the do not review Do not review or look at code without full context label Apr 6, 2025
@angad363 angad363 requested a review from manushajyasta30 April 6, 2025 01:53
@angad363 angad363 added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Apr 6, 2025
manushajyasta30
manushajyasta30 previously approved these changes Apr 6, 2025
akanksha7
akanksha7 previously approved these changes Apr 6, 2025
Copy link
Copy Markdown

@akanksha7 akanksha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logged in as admin and verified Teams section under Dashboard → Other Links. Checked element alignment, team member visibility, add/delete functionality, and card layout. Confirmed delete button text does not wrap with long names. Verified toggle behavior and alignment for all fields. All looks good, approving the PR.
Screenshot 2025-04-05 at 11 07 31 PM

Screenshot 2025-04-05 at 11 11 26 PM

Copy link
Copy Markdown

@sravankumarbodakonda sravankumarbodakonda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested the PR, and everything is working as expected. Approving it now
Screenshot 2025-04-07 at 8 01 46 AM
Screenshot 2025-04-07 at 8 02 02 AM
Screenshot 2025-04-07 at 8 02 26 AM

@angad363 angad363 dismissed stale reviews from akanksha7 and manushajyasta30 via 369920e April 9, 2025 01:43
Copy link
Copy Markdown
Contributor

@CodewithKoushica CodewithKoushica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested:

  • Verified the UI changes
  • Confirmed the functionality of populating team members in the popup

Everything is working smoothly — neat and clean implementation.
Looks good to me, ready to merge!
Screenshot 2025-04-08 at 11 02 24 PM

@one-community
Copy link
Copy Markdown
Member

Thank you all, merging!

@one-community one-community merged commit 18b71b2 into development Apr 9, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants