sundar_fix_unit_test_ForcePasswordUpdate.jsx#3508
Merged
Merged
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Member
|
Thank you all, merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
This PR addresses two separate issues in our frontend workflow:
Related PRS (if any):
None
Main changes explained:
Under NODE_ENV==='test', override toast.success/toast.error so they synchronously append a simple
Override renderInput() in ForcePasswordUpdate to destructure out darkMode and pass only the remaining props to the base form helper, removing the unknown-prop warning.
Use cross-env GENERATE_SOURCEMAP=false CI=false react-scripts build to:
This change prevents Node’s default ~1.4 GB heap from being exceeded during Webpack/Babel bundling on Netlify.
How to test:
npm installand...to run this PR locallynpm run test, all the test cases should pass.Screenshots
Note:
No new dependencies were added.
Production behavior in browsers and on Netlify (without GENERATE_SOURCEMAP=false) remains unchanged.