Vikas taking over for Vamshi - Update criteria for Bios ready to post to be based on Total Valid Weekly Summaries by guthaVamshi · Pull Request #3529 · OneCommunityGlobal/HighestGoodNetworkApp

guthaVamshi · 2025-05-15T18:22:07Z

Description

🛠️ What This PR Does

This update modifies the filter logic for the Bio Status in the Weekly Summaries Report under:

Owner Login → Reports → Weekly Summaries Report

Previously, qualification was based on the number of weeks a person had been on the team. This has now been corrected to reflect actual participation and contribution.

✅ Changes Made

Updated the Bio Status filter criteria to:
- Require 80 or more total volunteer hours (already implemented)
- Require 8 or more valid Weekly Summaries submitted (instead of 8+ weeks on the team)

🤔 Why This Matters

This ensures Bio Status is granted only to individuals who have consistently met expectations, regardless of how long they’ve been part of the project. It fairly excludes time off, missed weeks, or inactive periods and makes the system performance-based.

🎯 Outcome

Only individuals who have:

Logged 80+ total volunteer hours, AND
Submitted 8+ valid Weekly Summaries

will meet the Bio Status criteria.

🔗 Related PRs

Not related to any other PR.

🧪 How to Test

Check out the current branch
Run npm install and start the server locally
Clear site data/cache
Log in as an Owner user
Navigate to: Dashboard → Reports → Weekly Summaries Report
Click on Filter by Bio Status
Verify that results include only users who submitted 8+ valid Weekly Summaries

📸 Screenshots / Videos

Note:

Please refresh your cache before testing. Let us know if any edge cases are missed.

netlify · 2025-05-15T18:22:13Z

✅ Deploy Preview for highestgoodnetwork-dev ready!

Name	Link
🔨 Latest commit	`b4853f3`
🔍 Latest deploy log	https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/6941ab088e83810008664b58
😎 Deploy Preview	https://deploy-preview-3529--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

nikhilpittala16

I have tested the PR and everything works as expected.

PR.vid.34.mp4

CasstielP · 2025-05-23T16:07:24Z

Tested PR3529, setup was successfully, was able to render the targeted components, UI seemed well proportioned. Bio status toggle buttoned work properly that only displayed with users who submitted 8+ valid weekly summaries.

guthaVamshi · 2025-05-26T02:12:04Z

Tested PR3529, setup was successfully, was able to render the targeted components, UI seemed well proportioned. Bio status toggle buttoned work properly that only displayed with users who submitted 8+ valid weekly summaries.

Hello CasstieIP,

Thank you for reviewing the pull request. Since you seem to be satisfied with the testing, could you please update the status to "Approved" at your convenience?

Appreciate your time and support.

Ram-blip

Tested the PR and everything looks good! The Bio Status filter now correctly checks for 80+ hours and 8+ valid summaries in both light and dark mode. Great job and Approving the PR.

1709abhishek · 2025-06-07T16:24:24Z

It works fine. tested on my system. one thing i want to mention is, the UI for dark mode, for example the toggle buttons and very non user intuitive.

sonarqubecloud · 2025-10-24T20:23:10Z

Quality Gate failed

Failed conditions
E Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Anusha-Gali

Hi Kanishk,

I have tried to review your PR locally but was unable to do so due to node version difference. The application should officially support Node.js v20.x but your package.json has the node version "node": ">=14.0.0 <15".

SwathiAngadi · 2025-12-09T08:12:40Z

Hi Kanishk,

I checked into the above mentioned branch to review this PR, even I am facing the Node version issue, this branch requires version {"node":">=14.0.0 <15"} but app is running on V20

- Remove commented code from App.module.css - Fix overflow shorthand issue (use overflow-y instead of overflow) - Add generic font family fallback for FontAwesome - Remove unused styles import from App.jsx - Merge duplicate .issuesTableResponsive selector in IssueDashboard.module.css - Remove unused daysInTeam variable from BioFunction.jsx - Add PropTypes validation for summary.weeklySummariesCount in BioFunction and FormattedReport

kanishkagarwal6101 · 2025-12-11T18:49:49Z

Hi all, Thank you for the feedback, I have made the changes requested and fixed the conflicts and code quality issues, I request you to please test the branch again and let me know if it is satisfying the requirements, your feedback is greatly appreciated.

debadyuti23

Hi @kanishkagarwal6101 I have checked the changes in localhost. I can see some entries with weekly valid summaries with 0 as well. I have shared the video of my findings in the comment. Please let me know if this is expected or I might have missed anything.

PR_3529.mp4

…d of daysInTeam > 60

sonarqubecloud · 2025-12-16T18:55:46Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

kanishkagarwal6101 · 2025-12-16T18:59:18Z

@debadyuti23 I request you to please review the pr again, there was a minor caveat that i changed and committed. Hopefully all good now. Your feedback is greatly appreciated.

Anusha-Gali

Hi Kanishk,

I have re-reviewed your PR locally and even though there are summaries whose count is >8 (have shown in the screenshots below), they do not get filtered when i select the "Filter by Bio Status" toggle and it only shows one data.

ShreyaMP1999

Tested this PR locally as an Owner user. After enabling Filter by Bio Status, results do not match the expected behavior (users with 8+ valid Weekly Summaries). The filtered list still includes users with “Bio announcement: Not requested/posted” and “Weekly Summary: Not provided!”. Also seeing an API error toast (404 on filter list request), which may be affecting the filter logic. Screenshots attached.

Shravan-neelamsetty

Hi Kanishk, I tested this PR locally by logging in as Owner and navigating to Dashboard → Reports → Weekly Summaries Report. When I enabled "Filter by Bio Status," the results show only 1 user (Total Team Members: 1), despite there being multiple users in the system who should meet the criteria of 8+ valid weekly summaries. The single user shown has 48 valid summaries which exceeds the requirement, but the filter appears to be excluding other users who should also qualify. This suggests the filter logic is either too restrictive or not working correctly.

Vikas-8055

Hi Kanishk, I tested this PR locally by logging in as Owner and navigating to Dashboard → Reports → Weekly Summaries Report. When I enabled "Filter by Bio Status," the results show only 1 user (Total Team Members: 1), despite there being multiple users in the system who should meet the criteria of 8+ valid weekly summaries AND 80+ volunteer hours. The single user shown has 87 valid summaries which exceeds the requirement, but the filter appears to be excluding other users who should also qualify. This suggests the filter logic is either too restrictive or not working correctly.

abhinav-TB · 2026-01-15T16:28:52Z

Hi Kanishk, I have tested this PR locally. The filter does not display all having valid summaries > 8. It just displays one person

Ganesh112001

Hi Kanishk, I tested PR #3529 locally and verified that the Bio Status filter criteria update works correctly. After checking out the Vamshi-WeeklySummariesFilter branch and navigating to the Weekly Summaries Report at Dashboard → Reports → Weekly Summaries Report, I applied the "Filter by Bio Status" and confirmed that it now correctly filters users based on the updated criteria. The filter displays only users who have both 80 or more total volunteer hours AND 8 or more valid Weekly Summaries submitted, replacing the previous incorrect criteria that was based on weeks on the team. I verified that users meeting both conditions appear in the filtered results, while users with only one condition met (such as 80+ hours but fewer than 8 summaries, or 8+ summaries but fewer than 80 hours) are correctly excluded. The filter applies quickly in real-time, the clear filter functionality works properly, and no console errors were observed. This change ensures Bio Status is granted fairly based on actual participation and contribution rather than just time on the team, making the system performance-based as intended. Everything functions correctly and is ready for merge!

rohanrastogi311

Hi Kanishk,

Well done with this implementation.

Vikas-8055

I tested this PR locally by checking out the Vamshi-WeeklySummariesFilter branch, running npm install, and clearing site data before testing, with screenshots attached for reference. Logged in as an Owner and navigated to Dashboard → Reports → Weekly Summaries Report, enabled the “Filter by Bio Status,” and verified that the filter correctly returns only users who meet both criteria: 80+ total volunteer hours and 8+ valid Weekly Summaries submitted. Users who logged hours but missed weekly summaries are correctly excluded, confirming that the logic now evaluates actual participation rather than time on the team. The feature works as expected in both light and dark modes, with no console errors observed. Approved and ready to merge.

maithili20 · 2026-02-10T20:35:31Z

Hi @kanishkagarwal6101
I reviewed your PR and it works well in dark and light mode. But the filter does not seem to work correctly. I have multiple entries which have total valid weekly summaries>8 but they are not shown when filter is turned. I can only see 1 record. Please find the screenshots below

naznin07

Unit tests for BioFunction criteria and dropdown menu logic.

saisandeepkoritala

Hi Kaniskh,

I reviewed your PR and it works well in dark and light mode. But the filter seems to have issue. I have more than one entries which have total valid weekly summaries greater than 8 but they are not shown when filter is turned. I can only see 1 record. Please find the screenshots for refrence.

SharadhaKasiviswanathan · 2026-03-29T07:19:51Z

Tested locally on /weeklysummariesreport against the dev backend.
The new weeklySummariesCount >= 8 rule is taking effect, and the report page loaded correctly in my local test. I possibly think of two follow-ups that can be made before merge:

The permission description for highlightEligibleBios is still stale. It still says the bio highlight is based on “80 tangible hours, 60 days on the team...”, but the implemented rule is now based on weeklySummariesCount >= 8. Trying to update the permission text so it matches the actual behavior might be helpful.
The tests were not fully updated for this rule change. FormattedReport.test.jsx still uses weeklySummariesCount as a string and only raises a prop-type warning, and BioFunction.test.jsx still passes userId as a number and does not cover the new weeklySummariesCount >= 8 eligibility path. Updating/adding regression tests for the new bio-highlight/filter can also be done.

SharadhaKasiviswanathan · 2026-03-29T07:25:23Z

I found another issue while testing the Weekly Summaries Report locally:
When switching to the “Last Week” tab and older tabs, the “Filter by Bio Status” toggle behaves opposite to what the UI suggests: with the toggle off, the list is already filtered, and when the toggle is turned on, it stops behaving like a bio-only filter. This looks like a tab specific state or filter sync bug. I have attached the screenshots below.
Please try checking the bio filter behavior across all week tabs and adding a regression test for:

toggle off => no bio-status filtering
toggle on => only bio-eligible users are shown
same behavior remains correct after switching from “This Week” to “Last Week” and older tabs

rajanidi1999

This is a good step towards migrating to CSS modules, but there are a few concerns to address before merging. Converting global styles to modules (e.g., App.css) may unintentionally break existing styling across the app, especially with mixed usage of :global. Also noticed some duplicate className props and mixed usage of old and module-based class names, which could lead to bugs or styling inconsistencies. Recommend cleaning these up and verifying UI impact before final approval.

rajanidi1999

Hi,
I have tested your PR and its implemented successfully.

rithika-paii

Hi Vikas,

I reviewed PR #3529 and tested the Weekly Summaries Report filter locally in both light and dark modes. The overall functionality is clear, but I found a couple of issues:

Bio Status filter issue: When applying the filter, only one user is displayed, even though multiple users appear to meet the expected criteria (8+ valid weekly summaries). This suggests the filtering logic may not be correctly including all qualifying users.

Dark mode issue: In dark mode, the text on the page is not visible, indicating that the styling is not properly adapted for dark mode. This affects usability and readability.

Based on these observations, the filter logic and dark mode styling need further fixes before this PR can be approved.

guthaVamshi requested a review from mvreddy13 May 15, 2025 18:22

nikhilpittala16 approved these changes May 16, 2025

View reviewed changes

guthaVamshi added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label May 16, 2025

Ram-blip previously approved these changes May 27, 2025

View reviewed changes

1709abhishek self-requested a review June 7, 2025 16:24

1709abhishek previously approved these changes Jun 7, 2025

View reviewed changes

guthaVamshi dismissed stale reviews from 1709abhishek and Ram-blip via 9054146 July 9, 2025 18:12

guthaVamshi closed this Jul 9, 2025

guthaVamshi force-pushed the Vamshi-WeeklySummariesFilter branch from 9054146 to ebade00 Compare July 9, 2025 18:30

updated weeklysummarycount

e997933

guthaVamshi reopened this Jul 9, 2025

Fix Bio Status filter to use weeklySummariesCount instead of daysInTeam

eeda43d

one-community changed the title ~~Vamshi - Update criteria for Bios ready to post to be based on Total Valid Weekly Summaries~~ Kanishk taking over for Vamshi - Update criteria for Bios ready to post to be based on Total Valid Weekly Summaries Dec 4, 2025

Anusha-Gali suggested changes Dec 4, 2025

View reviewed changes

kanishkagarwal6101 added 3 commits December 11, 2025 11:27

fix: convert IssueDashboard.css to module CSS

e8c6a10

fix: prettier formatting in IssueDashboard

fa872e7

kanishkagarwal6101 requested a review from Anusha-Gali December 11, 2025 18:48

debadyuti23 reviewed Dec 13, 2025

View reviewed changes

fix: update Bio Status filter to use weeklySummariesCount >= 8 instea…

b4853f3

…d of daysInTeam > 60

Anusha-Gali suggested changes Dec 17, 2025

View reviewed changes

abhinav-TB self-assigned this Jan 3, 2026

ShreyaMP1999 reviewed Jan 3, 2026

View reviewed changes

abhinav-TB removed their assignment Jan 3, 2026

Shravan-neelamsetty reviewed Jan 10, 2026

View reviewed changes

Vikas-8055 reviewed Jan 10, 2026

View reviewed changes

Ganesh112001 approved these changes Jan 16, 2026

View reviewed changes

rohanrastogi311 approved these changes Jan 24, 2026

View reviewed changes

Vikas-8055 approved these changes Jan 31, 2026

View reviewed changes

naznin07 approved these changes Mar 7, 2026

View reviewed changes

saisandeepkoritala reviewed Mar 27, 2026

View reviewed changes

one-community changed the title ~~Kanishk taking over for Vamshi - Update criteria for Bios ready to post to be based on Total Valid Weekly Summaries~~ Vikas taking over for Vamshi - Update criteria for Bios ready to post to be based on Total Valid Weekly Summaries Apr 5, 2026

rajanidi1999 approved these changes Apr 12, 2026

View reviewed changes

rajanidi1999 approved these changes Apr 14, 2026

View reviewed changes

rithika-paii requested changes Apr 21, 2026

View reviewed changes

Uh oh!

Conversation

guthaVamshi commented May 15, 2025

Description

🛠️ What This PR Does

✅ Changes Made

🤔 Why This Matters

🎯 Outcome

🔗 Related PRs

🧪 How to Test

📸 Screenshots / Videos

Note:

Uh oh!

netlify Bot commented May 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for highestgoodnetwork-dev ready!

Uh oh!

nikhilpittala16 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CasstielP commented May 23, 2025

Uh oh!

guthaVamshi commented May 26, 2025

Uh oh!

Ram-blip left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

1709abhishek commented Jun 7, 2025

Uh oh!

sonarqubecloud Bot commented Oct 24, 2025

Quality Gate failed

Uh oh!

Anusha-Gali left a comment

Choose a reason for hiding this comment

Uh oh!

SwathiAngadi commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kanishkagarwal6101 commented Dec 11, 2025

Uh oh!

debadyuti23 left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented Dec 16, 2025

Quality Gate passed

Uh oh!

kanishkagarwal6101 commented Dec 16, 2025

Uh oh!

Anusha-Gali left a comment

Choose a reason for hiding this comment

Uh oh!

ShreyaMP1999 left a comment

Choose a reason for hiding this comment

Uh oh!

Shravan-neelamsetty left a comment

Choose a reason for hiding this comment

Uh oh!

Vikas-8055 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

abhinav-TB commented Jan 15, 2026

Uh oh!

Ganesh112001 left a comment

Choose a reason for hiding this comment

Uh oh!

rohanrastogi311 left a comment

Choose a reason for hiding this comment

Uh oh!

Vikas-8055 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maithili20 commented Feb 10, 2026

Uh oh!

naznin07 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

netlify Bot commented May 15, 2025 •

edited

Loading

nikhilpittala16 left a comment •

edited

Loading

Ram-blip left a comment •

edited

Loading

SwathiAngadi commented Dec 9, 2025 •

edited

Loading

Vikas-8055 left a comment •

edited

Loading

Vikas-8055 left a comment •

edited

Loading

naznin07 left a comment •

edited

Loading